Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a crucial security enhancement by setting a default HTTP_DENY_LIST. This prevents Server-Side Request Forgery (SSRF) vulnerabilities by default, which is a significant improvement over the previous behavior of allowing all requests when the environment variable was not set. The implementation is sound. I have provided one suggestion to refactor duplicated code into a helper function to improve maintainability.
christopherholland-workday
requested review from
0xi4o,
igor-magun-wd and
yau-wd
yau-wd
approved these changes
Feb 4, 2026
vellanki-santhosh
pushed a commit
to vellanki-santhosh/Flowise
that referenced
this pull request
Feb 17, 2026
* Create default HTTP_DENY_LIST * refactor(httpSecurity.ts): add getHttpDenyList function --------- Co-authored-by: yau-wd <yau.ong@workday.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of authorizing the call if the
HTTP_DENY_LISTis not set, create a default in code equal to defaults set elsewhere.