Skip to content

Remove ability for customers to use unprotected HTTP modules#5727

Merged
yau-wd merged 3 commits intomainfrom
custom-function-sandbox
Feb 10, 2026
Merged

Remove ability for customers to use unprotected HTTP modules#5727
yau-wd merged 3 commits intomainfrom
custom-function-sandbox

Conversation

@christopherholland-workday
Copy link
Contributor

Remove ability for customers to use unprotected HTTP modules, they should use secure dependencies instead.

axios and node-fetch are secured via module replacement

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @christopherholland-workday, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's security by restricting the direct use of built-in Node.js HTTP and network modules. By removing http, https, net, and tls from the list of allowed built-in dependencies, the system ensures that users leverage secure, pre-vetted alternatives like axios and node-fetch, which are already managed through robust module replacement mechanisms.

Highlights

  • Security Enhancement: Removed direct access to potentially insecure built-in Node.js modules (http, https, net, tls) from the defaultAllowBuiltInDep list. This change encourages the use of secure, pre-configured alternatives for network requests.
Changelog
  • packages/components/src/utils.ts
    • Removed 'http', 'https', 'net', and 'tls' from the defaultAllowBuiltInDep array, preventing direct usage of these built-in modules.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to enhance security by preventing custom code from using unprotected HTTP modules. It achieves this by removing http, https, net, and tls from the list of built-in modules allowed within the NodeVM sandbox. While the intention is good, I've identified a critical issue: this change will likely break several allowed external dependencies (e.g., AWS SDK) that depend on these core modules, causing widespread functional regressions. My review includes a detailed comment on this critical issue.

@yau-wd yau-wd merged commit b7e836c into main Feb 10, 2026
7 checks passed
@yau-wd yau-wd deleted the custom-function-sandbox branch February 10, 2026 14:20
vellanki-santhosh pushed a commit to vellanki-santhosh/Flowise that referenced this pull request Feb 17, 2026
…AI#5727)

* Remove ability for customers to use unprotected HTTP modules, they should use secured dependencies instead

* Remove ability for customers to use unprotected HTTP modules

---------

Co-authored-by: yau-wd <yau.ong@workday.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants