refactor(agentflow): enhance ESLint configuration and improve test coverage#5866
Conversation
jocelynlin-wd
commented
Feb 28, 2026
jocelynlin-wd
commented
- Updated ESLint configuration to include TypeScript resolver for improved import handling.
- Added restrictions on importing from features to enforce architectural boundaries.
- Enhanced test coverage for various components (tier 2 & 3), including ConnectionLine and NodeOutputHandles.
- Updated architecture documentation to reflect recent changes in file structure and component organization.
…verage - Updated ESLint configuration to include TypeScript resolver for improved import handling. - Added restrictions on importing from features to enforce architectural boundaries. - Enhanced test coverage for various components, including ConnectionLine and NodeOutputHandles. - Updated architecture documentation to reflect recent changes in file structure and component organization.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request delivers a significant improvement to the agentflow package by enhancing the ESLint configuration to enforce architectural boundaries, massively increasing test coverage across components, hooks, and contexts, and updating the corresponding documentation. The changes are of high quality, with well-written and comprehensive tests. A notable architectural improvement is the refactoring to remove a core to features dependency, strengthening the modular design. The documentation updates in ARCHITECTURE.md, TESTS.md, and README.md are clear and align perfectly with the code changes. Overall, this is an excellent contribution that greatly improves the project's quality and maintainability.
jocelynlin-wd
requested review from
harshit-flowise,
j-sanaa,
muratkaratekeli and
tianwei-liu
|
|
||
| import type { AxiosInstance } from 'axios' | ||
|
|
||
| import { EditNodeDialogProps } from '@/features/node-editor/EditNodeDialog' |
There was a problem hiding this comment.
core should not access anything in features
| }, | ||
| 'import/resolver': { | ||
| typescript: { | ||
| project: './tsconfig.json' |
There was a problem hiding this comment.
allow lint to check imports with alias
- manually resolve conflict in pnpm-lock.yaml
2 participants
