test(agentflow): update tests to remove console warnings#5878
test(agentflow): update tests to remove console warnings#5878jocelynlin-wd merged 2 commits intomainfrom
Conversation
jocelynlin-wd
commented
Mar 2, 2026
- Modified tests for ConnectionLine to wrap components in SvgWrapper for proper rendering of SVG elements.
- Updated GenerateFlowDialog tests to include async wait for chat models to be loaded before assertions.
- Enhanced test coverage and reliability by ensuring correct rendering contexts for components.
…o use SvgWrapper for rendering - Modified tests for ConnectionLine to wrap components in SvgWrapper for proper rendering of SVG elements. - Updated GenerateFlowDialog tests to include async wait for chat models to be loaded before assertions. - Enhanced test coverage and reliability by ensuring correct rendering contexts for components.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the reliability and correctness of existing tests within the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively addresses console warnings in the tests by wrapping SVG components correctly and waiting for asynchronous operations to complete. The changes are correct and improve test stability. The suggestions to further improve the test code's maintainability by reducing duplication are still valid and recommended for a cleaner test suite.