Skip to content

test(agentflow): update tests to remove console warnings#5878

Merged
jocelynlin-wd merged 2 commits intomainfrom
refactor/agentflow-fix-test-console-warning
Mar 2, 2026
Merged

test(agentflow): update tests to remove console warnings#5878
jocelynlin-wd merged 2 commits intomainfrom
refactor/agentflow-fix-test-console-warning

Conversation

@jocelynlin-wd
Copy link
Contributor

  • Modified tests for ConnectionLine to wrap components in SvgWrapper for proper rendering of SVG elements.
  • Updated GenerateFlowDialog tests to include async wait for chat models to be loaded before assertions.
  • Enhanced test coverage and reliability by ensuring correct rendering contexts for components.

…o use SvgWrapper for rendering

- Modified tests for ConnectionLine to wrap components in SvgWrapper for proper rendering of SVG elements.
- Updated GenerateFlowDialog tests to include async wait for chat models to be loaded before assertions.
- Enhanced test coverage and reliability by ensuring correct rendering contexts for components.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the reliability and correctness of existing tests within the agentflow package. The changes primarily involve adjusting test rendering environments for SVG components and incorporating asynchronous waiting mechanisms for API calls, leading to more robust and warning-free test suites.

Highlights

  • Test Environment Setup: Modified ConnectionLine tests to wrap components in an SvgWrapper for correct rendering of SVG elements, addressing console warnings related to SVG context.
  • Asynchronous Test Reliability: Updated GenerateFlowDialog tests to include async and await waitFor calls, ensuring chat models are fully loaded before assertions are made, which improves test stability.
Changelog
  • packages/agentflow/src/features/canvas/components/ConnectionLine.test.tsx
    • Imported ReactNode and defined a new SvgWrapper functional component.
    • Applied the SvgWrapper to all render calls within the ConnectionLine tests to provide a proper SVG context.
  • packages/agentflow/src/features/generator/GenerateFlowDialog.test.tsx
    • Converted the test 'should render dialog when open is true' to an async function and added a waitFor assertion for mockGetChatModels.
    • Converted the test 'should show cancel button when not loading' to an async function and added a waitFor assertion for mockGetChatModels.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses console warnings in the tests by wrapping SVG components correctly and waiting for asynchronous operations to complete. The changes are correct and improve test stability. The suggestions to further improve the test code's maintainability by reducing duplication are still valid and recommended for a cleaner test suite.

@jocelynlin-wd jocelynlin-wd merged commit d6ee015 into main Mar 2, 2026
7 checks passed
@jocelynlin-wd jocelynlin-wd deleted the refactor/agentflow-fix-test-console-warning branch March 2, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants