feat(agentflow): axios client includes cookies in requests#5919
feat(agentflow): axios client includes cookies in requests#5919ginna-baker merged 2 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Axios client configuration to include cookies in requests. This change is crucial for enabling server-side authentication, as it allows the server to receive and process necessary credentials for secure communication. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds withCredentials: true to the axios client configuration to enable cookie-based authentication. While the change is functionally correct for its purpose, it lacks corresponding test coverage. My review includes a comment to add a test case, which will help ensure the change is robust and prevent future regressions.
| baseURL: `${apiBaseUrl}/api/v1`, | ||
| headers | ||
| headers, | ||
| withCredentials: true |
|
Agentflow already accepts optional token to be used for APIs. This will introduce two auth mechanism running simultaneously https://github.com/FlowiseAI/Flowise/blob/main/packages/agentflow/src/core/types/index.ts#L190 |
We need axios to include cookies in requests so that the server can authenticate.