fix(ci): avoid workspace: protocol error in publish-agentflow workflow#5946
fix(ci): avoid workspace: protocol error in publish-agentflow workflow#5946jocelynlin-wd merged 3 commits intomainfrom
Conversation
Use working-directory instead of pnpm exec for npm version, and pnpm pack instead of pnpm exec npm pack, to avoid npm encountering pnpm's workspace: protocol. Sort deps alphabetically in package.json to prevent future noise from npm tooling. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves critical CI issues within the Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses a CI issue related to the workspace: protocol in pnpm. The provided change sorts the dependencies and peerDependencies in packages/agentflow/package.json alphabetically. This is a good housekeeping measure that improves maintainability and helps avoid future diff noise. The change is correct and I have no further comments.
Note: Security Review has been skipped due to the limited scope of the PR.
npm version and pnpm version both fail in this monorepo because they resolve the full dependency tree and choke on pnpm's workspace: protocol. Replace with npx semver (compute version) + npm pkg set (write version). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix an issue in a test run https://github.com/FlowiseAI/Flowise/actions/runs/22929422859/job/66547466870
Summary
working-directory: packages/agentflowwith plainnpm versioninstead ofpnpm --filter exec npm version, which exposed npm to pnpm'sworkspace:protocol and causedEUNSUPPORTEDPROTOCOLerrorspnpm packinstead ofpnpm exec npm packfor the same reasondependenciesandpeerDependenciesalphabetically inpackages/agentflow/package.jsonto prevent future diff noise from npm toolingTest plan
bump=prereleaseandtag=devand verify the "Set version" step succeedsTest
dry-runwith updated script: https://github.com/FlowiseAI/Flowise/actions/runs/22932158208/job/66555843045 (the job is rejected manually to avoid publishing to npm)🤖 Generated with Claude Code