feat(agentflow): MessagesInput, StructuredOutputBuilder + ExpandTextDialog (FLOWISE-263, FLOWISE-267)#5965
Conversation
…ialog (FLOWISE-263, FLOWISE-267) Wire MessagesInput and StructuredOutputBuilder atoms into EditNodeDialog for agentMessages/llmMessages and agentStructuredOutput/llmStructuredOutput array params. Extract shared ExpandTextDialog atom used by both MessagesInput and NodeInputHandler for expanding multiline text fields. - MessagesInput: role dropdown + multiline content with variable/expand icons - StructuredOutputBuilder: key/type/description fields with conditional enum values and JSON schema fields - ExpandTextDialog: reusable expand dialog for long text editing - EditNodeDialog: name-based routing for specialized array components - maxItems forward-compat guard on Add buttons - Remove dead default exports for barrel-only modules Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user interface for configuring Agentflow nodes by introducing specialized and more intuitive input components. It improves the editing experience for complex data structures like conversational messages and structured output definitions, making node configuration more efficient and user-friendly. The addition of a reusable text expansion dialog further streamlines the handling of lengthy text inputs across the application. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several new, well-tested components to enhance the agentflow node editor: MessagesInput for message lists, StructuredOutputBuilder for JSON schemas, and a reusable ExpandTextDialog. The implementation is solid, and the integration into EditNodeDialog and NodeInputHandler is clean. My feedback focuses on a pattern of mutating refs during the render phase in the new list-builder components, which aligns with general React best practices. I've suggested an alternative that aligns with existing patterns in your codebase to improve consistency and adherence to React principles.
f29df53 to
9518e79
Compare
…n, add info tooltips for Enum Values and JSON Schema, and implement ExpandTextDialog for JSON Schema editing. Update tests to cover new features and interactions.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces three new UI components: MessagesInput, StructuredOutputBuilder, and ExpandTextDialog. The ExpandTextDialog is a reusable component for editing long text, which is then integrated into both MessagesInput and NodeInputHandler. The MessagesInput component provides a specialized array input for message entries with role dropdowns and multiline content, while StructuredOutputBuilder offers a specialized array input for structured output schemas with key, type, and description fields, including conditional fields for enums and JSON schemas. The EditNodeDialog has been updated to route to these new specialized components for relevant array parameters, enhancing the user experience for these specific input types. Comprehensive unit and integration tests have been added for all new components and their interactions, ensuring the correctness and stability of the new features.
| </Button> | ||
|
|
||
| {/* Expand dialog for JSON Schema */} | ||
| {expandOpen && ( |
There was a problem hiding this comment.
use Text dialog for all text input first, will switch to use json editor in FLOWISE-230
| {title} | ||
| </Typography> | ||
| )} | ||
| <TextField |
There was a problem hiding this comment.
will update this component to support rich text in FLOWISE-342
Summary
agentMessages/llmMessagesarray paramsagentStructuredOutput/llmStructuredOutputarray paramsTest plan
🤖 Generated with Claude Code
Recordings:
message-array-editor.mov
structured-output-builder.mov