Fix Credential Data Leak

[christopherholland-workday]

Flowise-369

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the security of the application by preventing the inadvertent exposure of sensitive encrypted credential data through the API. It ensures that credential objects returned to clients no longer contain the encryptedData field, thereby mitigating a potential data leak vulnerability and improving overall data protection.

Highlights

• Security Fix: Implemented a fix to prevent the encryptedData field from being exposed in credential API responses, addressing a potential data leak.
• Credential Data Handling: Modified the credential retrieval logic to explicitly omit the sensitive encryptedData field before returning credential objects.
• Test Coverage: Added a new test case to ensure that the encryptedData property is not present in the API response when fetching credentials.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a credential data leak. My review identifies that while the current changes address some paths, a critical data leak in an unmodified code path within getAllCredentials remains. As per repository guidelines, this issue is suggested for a follow-up, but its critical nature warrants attention. Please see my detailed comment for specifics.

[yau-wd]

Left comments in Jira