Bugfix/Silent fallback to vm2 for sandbox execution#6206
Merged
HenryHengZJ merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
Contributor
Author
|
#6168 introduced changes that force users to use E2B for sandbox, reverting that as its not a must for self hosted OSS users to use that, silent fallback to using patched version of vm2 |
henry-heng-wd
approved these changes
Apr 13, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the executeJavaScriptCode function in utils.ts to introduce a silent fallback when useSandbox is enabled but the E2B_APIKEY is missing. Previously, this condition triggered an error. The reviewer noted that this change could lead to insecure code execution using the deprecated vm2 library without the user's knowledge, violating the principle against silent configuration fallbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
silent fallback to vm2 for sandbox execution