Skip to content

Bring canvas buttons to same z-index level#6235

Merged
VaidikFlow merged 3 commits intomainfrom
fix/canvas-buttons-on-same-z-level
Apr 16, 2026
Merged

Bring canvas buttons to same z-index level#6235
VaidikFlow merged 3 commits intomainfrom
fix/canvas-buttons-on-same-z-level

Conversation

@VaidikFlow
Copy link
Copy Markdown
Contributor

@VaidikFlow VaidikFlow commented Apr 16, 2026

Bring canvas buttons to z-index 10 so that they do not show over top containers using embedded canvas

Screenshot 2026-04-16 at 12 47 29 PM Screenshot 2026-04-16 at 7 51 51 AM

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adjusts z-index values for UI components in the agentflow package to manage layering. Feedback highlights a formatting issue and a logic inconsistency in the ValidationFeedback component where the button and its associated overlay have mismatched z-indices. Furthermore, the reduction of Z_INDEX_DRAWER in the node palette impacts both the trigger and the overlay, potentially causing the drawer to be obscured by other canvas elements; it is recommended to use separate z-index values for these components.

Comment thread packages/agentflow/src/features/canvas/components/ValidationFeedback.tsx Outdated
Comment thread packages/agentflow/src/features/node-palette/AddNodesDrawer.tsx
@VaidikFlow VaidikFlow merged commit 1194c97 into main Apr 16, 2026
7 checks passed
@jocelynlin-wd
Copy link
Copy Markdown
Contributor

image

looks like the add node button is fixed, but not the validation button.
when a modal is opened, add nodes is rendered correctly but validate button still not correct

mt: 1.5,
width: 400,
zIndex: 1200
zIndex: 10
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change is actually not necessary, since we want the button to be more visible when validate is clicked? @j-sanaa what do you think?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this. To me it makes sense to have the validation panel visible on top of other UI elements when clicked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants