Skip to content

Fix/agentflow Fixing agentflow UI style and make it similar to v2#6280

Merged
j-sanaa merged 18 commits into
mainfrom
fix/agentflow-node-output
Apr 27, 2026
Merged

Fix/agentflow Fixing agentflow UI style and make it similar to v2#6280
j-sanaa merged 18 commits into
mainfrom
fix/agentflow-node-output

Conversation

@j-sanaa
Copy link
Copy Markdown
Contributor

@j-sanaa j-sanaa commented Apr 23, 2026

  1. Fixed Node outputs ( FLOWISE-511)
    Before:
image

After:
image

  1. Fixed node displaying label (FLOWISE-512)

Before:
image

After:
image

  1. Fixed tool Input Arguments are not populated when selecting tools (FLOWISE-520)
    before:
image

After:
image

  1. Apply consistent typography across agentflow (FLOWISE-601)
    Before:
Typography.before.fix.mov

After:

Fixing.Typography.mov
  1. Fix inconsistent spacing between fields (FLOWISE-602)

  2. Fix styling of variable select
    Before:

image

after:
image

  1. Fix Source dialog window size:
    Before:
image

After:
image

  1. FIx input fields background color
    Before:
image

After:
image

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the theme system by introducing a centralized token scale for typography and colors, updating multiple components to use these tokens. It also enhances the ArrayInput component to support structured node outputs as variables and ensures parent-level inputs are accessible within array items. Review feedback highlights the need to restore dark mode compatibility for mention chips, avoid hardcoded colors in theme overrides by using tokens, and improve the usability of the ExpandTextDialog by restoring monospace fonts and flexible height for structured data.

Comment on lines +93 to +98
backgroundColor: '#b3f0b8',
borderRadius: '0.4rem',
boxDecorationBreak: 'clone',
WebkitBoxDecorationBreak: 'clone',
color: '#0d7115',
padding: '0.1rem 0.3rem'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The .mention styling has been updated with hardcoded hex colors (#b3f0b8 and #0d7115), replacing the previous theme-aware logic. This will likely cause accessibility and contrast issues in dark mode, as these light colors will not adapt to the dark background. It is recommended to restore the conditional logic for dark mode while keeping the new layout properties.

Suggested change
backgroundColor: '#b3f0b8',
borderRadius: '0.4rem',
boxDecorationBreak: 'clone',
WebkitBoxDecorationBreak: 'clone',
color: '#0d7115',
padding: '0.1rem 0.3rem'
backgroundColor: mode === 'dark' ? 'rgba(76, 175, 80, 0.2)' : '#b3f0b8',
borderRadius: '0.4rem',
boxDecorationBreak: 'clone',
WebkitBoxDecorationBreak: 'clone',
color: mode === 'dark' ? '#81c784' : '#0d7115',
padding: '0.1rem 0.3rem'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same color scheme is used in v2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you share screenshot of both versions (gemini suggested theme vs v2) and loop in Henry to see if we should fix the contrast & accessibility issue instead?

Copy link
Copy Markdown
Contributor Author

@j-sanaa j-sanaa Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HenryHengZJ
Wanted to check with you if you prefet gemini's suggestion for variable syntax highlighting or continue with the existing implementation

Gemini:
Gemini suggestion

Original:
Current implementatiom

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original is better, Gemini's is hard to see in dark mode

Comment thread packages/agentflow/src/core/theme/createAgentflowTheme.ts Outdated
Comment on lines 129 to 135
maxRows={15}
value={localValue}
disabled={disabled}
onChange={(e) => setLocalValue(e.target.value)}
placeholder={placeholder}
data-testid='source-input'
inputProps={{ style: { fontFamily: 'monospace', fontSize: '0.85em' } }}
/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Setting maxRows={15} to match minRows={15} makes the text area fixed-height, which can significantly hinder the user experience when viewing or editing long content (e.g., large JSON or code blocks) as it forces scrolling within a small viewport. Additionally, the removal of the monospace font styling (fontFamily: 'monospace') makes it harder to read structured data or code, which is the primary use case for the 'Source' input. Consider allowing the field to expand and restoring the monospace font.

                            maxRows={30}
                            value={localValue}
                            disabled={disabled}
                            onChange={(e) => setLocalValue(e.target.value)}
                            placeholder={placeholder}
                            data-testid='source-input'
                            inputProps={{ style: { fontFamily: 'monospace', fontSize: '0.85em' } }}
                        />

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2 also has a fixed size of the dialog and no monospace font is used

@j-sanaa j-sanaa marked this pull request as ready for review April 24, 2026 16:28
@j-sanaa j-sanaa requested a review from jocelynlin-wd April 24, 2026 16:29
@j-sanaa j-sanaa requested review from HenryHengZJ and henry-heng-wd and removed request for henry-heng-wd and jocelynlin-wd April 24, 2026 21:21
Copy link
Copy Markdown
Contributor

@jocelynlin-wd jocelynlin-wd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just need to confirm dark mode behaviour

@j-sanaa j-sanaa merged commit 3d69bae into main Apr 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants