chore: update Node.js version consistency and optimize Docker build#6285
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js version to 20.20.2 and modifies the Docker build process to exclude specific UI packages. Feedback suggests that the pnpm build command in the Dockerfile requires a double-dash separator to correctly pass filters to Turbo. Additionally, it is recommended to update the engine constraints in workspace packages, such as the server package, to maintain consistency with the root configuration.
- Bump .nvmrc from v20.19.2 to v20.20.2 to match CI - Narrow package.json engines to ^20 across root and packages/server - Exclude @flowiseai/agentflow and @flowiseai/observe from Docker build to save ~40-50s per build (sdk packages not needed for app runtime) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jocelynlin-wd
force-pushed
the
chore/node-version-docker-build-optimization
branch
from
de8940f to
ecfa502
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Node.js version to 20.20.2 in .nvmrc and restricts the engine requirement to Node 20 in the package configuration files. Additionally, the Dockerfile build command is modified to exclude specific SDK packages using pnpm filters to optimize the build process. I have no feedback to provide.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the project's Node.js version to 20.20.2 and introduces a specialized build:docker script that excludes specific SDK packages to optimize the Docker build process. It also simplifies the Node.js engine requirements across the repository. The review feedback suggests relaxing the engine constraint from ^20 to >=20 to ensure compatibility with newer LTS versions, such as Node 22, which improves the developer experience and future-proofs the application.
|
@jocelynlin-wd do we plan to also exlucde the new packages from |
The exclusion is intentional only for the Docker build. pnpm build keeps building all packages since local dev and CI still need agentflow and observe for testing and publishing. That's why we introduced the separate build:docker script. |
|
@jocelynlin-wd node20 is deprecated, can we use 24? https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ |
Yes we need to look into this. Created FLOWISE-629 to handle the Node.js version upgrade. |
3 participants
Summary
.nvmrcfromv20.19.2tov20.20.2to match CIpackage.jsonengines from>=18.15.0 <19.0.0 || ^20to^20since everything is now on Node 20@flowiseai/agentflowand@flowiseai/observefrom Docker build — these UI-only SDK packages are not needed for the app runtime, saving ~40–50s per Docker buildFLOWISE-619
Test plan
🤖 Generated with Claude Code