Skip to content

Bugfix/Missing Theme in FullPageChat#353

Merged
HenryHengZJ merged 1 commit intomainfrom
bugfix/Missing-Theme-Property
Mar 16, 2026
Merged

Bugfix/Missing Theme in FullPageChat#353
HenryHengZJ merged 1 commit intomainfrom
bugfix/Missing-Theme-Property

Conversation

@HenryHengZJ
Copy link
Copy Markdown
Contributor

Enhance type exports in index.d.ts and update theme import path in web.d.ts

@HenryHengZJ HenryHengZJ linked an issue Mar 16, 2026 that may be closed by this pull request
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where the theme was not correctly applied or recognized within the FullPageChat component. The changes ensure that critical types, specifically FullProps and BubbleTheme, are properly exported from the main module entry point and that their import paths are correctly resolved across the codebase. This allows for consistent theme application and type safety for the full-page chat interface.

Highlights

  • Type Exports: Exported FullProps and BubbleTheme types from the main index.d.ts and src/index.ts files to make them globally accessible.
  • Theme Import Path: Updated the import path for BubbleTheme in web.d.ts to correctly reference the newly exported type from the module's root, resolving a potential theme-related bug in FullPageChat.
Changelog
  • dist/index.d.ts
    • Added exports for FullProps and BubbleTheme types.
  • dist/index.d.ts.map
    • Updated the source map to reflect the new type exports.
  • dist/web.d.ts
    • Modified the import path for BubbleTheme to reference the root export.
  • src/index.ts
    • Added exports for FullProps and BubbleTheme types.
Activity
  • No human activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@HenryHengZJ HenryHengZJ merged commit 16c193a into main Mar 16, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances type exports and updates theme import paths to address a missing theme in FullPageChat. The changes to src/index.ts to export additional types are correct. However, the modifications to dist/web.d.ts are problematic as this appears to be a generated file. Edits to generated files are typically overwritten by build processes. My review comment highlights this issue to ensure the changes are made in the correct source file for persistence.

Comment thread dist/web.d.ts
chatflowConfig?: Record<string, unknown> | undefined;
observersConfig?: import("./components/Bot").observersConfigType | undefined;
theme?: import("./features/bubble/types").BubbleTheme | undefined;
theme?: import(".").BubbleTheme | undefined;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This file (dist/web.d.ts) appears to be a generated declaration file. The corresponding sourcemap (dist/web.d.ts.map) indicates that src/web.ts is the source file. Changes should be made in the source file src/web.ts and not directly in the dist folder, as they will likely be overwritten by the build process. Please apply this change, and the similar one on line 18, to the source file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing theme types

1 participant