Skip to content

Cleanup before CRAN release#9

Merged
e-kotov merged 27 commits intomasterfrom
prep-for-CRAN-release
Aug 30, 2024
Merged

Cleanup before CRAN release#9
e-kotov merged 27 commits intomasterfrom
prep-for-CRAN-release

Conversation

@e-kotov
Copy link
Copy Markdown
Collaborator

@e-kotov e-kotov commented Aug 29, 2024

@ilyabo hi! I made some changes to the package:

@e-kotov e-kotov requested a review from ilyabo August 29, 2024 12:18
@e-kotov e-kotov added the documentation Improvements or additions to documentation label Aug 29, 2024
@e-kotov e-kotov added this to the publish to CRAN milestone Aug 29, 2024
@e-kotov e-kotov added the enhancement New feature or request label Aug 29, 2024
Copy link
Copy Markdown
Member

@ilyabo ilyabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @e-kotov!

lgtm, I just noticed a few URL which should be changed.
I enabled google pages and uploaded the preview image.

Comment thread CITATION.cff Outdated
Comment thread codemeta.json Outdated
Comment thread inst/CITATION Outdated
@e-kotov
Copy link
Copy Markdown
Collaborator Author

e-kotov commented Aug 30, 2024

@ilyabo sorry about the links to my other package, I will regenerate the metadata. It go in there while i was copying over some code for reuse.

Co-authored-by: Ilya Boyandin <ilyabo@gmail.com>
e-kotov and others added 3 commits August 30, 2024 15:09
Co-authored-by: Ilya Boyandin <ilyabo@gmail.com>
Co-authored-by: Ilya Boyandin <ilyabo@gmail.com>
@e-kotov
Copy link
Copy Markdown
Collaborator Author

e-kotov commented Aug 30, 2024

Closes #2 .

@ilyabo
Copy link
Copy Markdown
Member

ilyabo commented Aug 30, 2024

No worries. I will need to change the FlowmapBlue project config (namely convert it to a monorepo and publish a library, right now it's a nextjs app). Will try to find time for it.

@e-kotov e-kotov merged commit 41c1422 into master Aug 30, 2024
@e-kotov e-kotov deleted the prep-for-CRAN-release branch August 30, 2024 12:16
@e-kotov
Copy link
Copy Markdown
Collaborator Author

e-kotov commented Aug 30, 2024

@ilyabo

I enabled google pages and uploaded the preview image.

great! Final thing to do is to add https://flowmapblue.github.io/flowmapblue.R/ (or just enable automatic URL to gh-pages) in the front page repo settings. Like so:

Screenshot 2024-08-30 at 14 18 34

I will also add this gh-pages link to package readme and metadata and submit to CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants