Skip to content

!!! TASK: Require manual configuration of autocomplete#42

Merged
daniellienert merged 3 commits intomasterfrom
instructions-custom-index-name
Jun 25, 2018
Merged

!!! TASK: Require manual configuration of autocomplete#42
daniellienert merged 3 commits intomasterfrom
instructions-custom-index-name

Conversation

@kdambekalns
Copy link
Copy Markdown
Member

See #38 for the problem this "solves" (for the time being.)

@kitsunet
Copy link
Copy Markdown
Member

kitsunet commented Feb 7, 2018

It's still a bc change, IMHO we must fix it (eg. by reverting and releasing it as major version)

@daniellienert
Copy link
Copy Markdown
Contributor

daniellienert commented Feb 7, 2018

I suggest to remove the autocomplete configuration from the settings and only mention in the radme, how to enable this feature for your specific index name.

@kdambekalns
Copy link
Copy Markdown
Member Author

Well, then we need to move the settings and the needed nodetype changes (adding the suggestable mixin) to the readme…

@DrillSergeant
Copy link
Copy Markdown

I also stumbled into problems with searchPlugin when using it together with the one-index-per-dimensioncombination strategy (Flowpack/Flowpack.ElasticSearch.ContentRepositoryAdaptor#245)

My problem was the missing field __dimensionCombinationHash which is expected by the SuggestionMixin. As a result my document-nodes were indexed, but almost emtpy. I solved it by not using the mixin:

'Neos.Neos:Document':
  superTypes:
    'Flowpack.SearchPlugin:SuggestableMixin': FALSE

Took a while to figure it out. I will comment this in the mentioned pull-request, but not having the mixin applied by default would prevent others from that problem.

kitsunet
kitsunet previously approved these changes Apr 23, 2018
@kitsunet kitsunet dismissed their stale review April 23, 2018 17:23

Because it's mine.

This removes the default addition of the AutocompletableMixin and the
SuggestableMixin from the package, as well as the analyzer setup done
in the settings.

Instead the README is amended with instructions on how to use this.

This avoids errors when using a custom index name.
@kdambekalns
Copy link
Copy Markdown
Member Author

Finally tackled this and removed the settings in favor of documenting their use. Please (re-)review, @daniellienert and @kitsunet.

@kdambekalns kdambekalns changed the title TASK: Add instructions for using custom index name !!! TASK: Require manual configuration of autocomplete May 31, 2018
@kdambekalns
Copy link
Copy Markdown
Member Author

Ping…

@daniellienert daniellienert merged commit 6758657 into master Jun 25, 2018
@daniellienert daniellienert deleted the instructions-custom-index-name branch June 25, 2018 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants