!!! TASK: Require manual configuration of autocomplete#42
!!! TASK: Require manual configuration of autocomplete#42daniellienert merged 3 commits intomasterfrom
Conversation
|
It's still a bc change, IMHO we must fix it (eg. by reverting and releasing it as major version) |
|
I suggest to remove the autocomplete configuration from the settings and only mention in the radme, how to enable this feature for your specific index name. |
|
Well, then we need to move the settings and the needed nodetype changes (adding the suggestable mixin) to the readme… |
|
I also stumbled into problems with searchPlugin when using it together with the one-index-per-dimensioncombination strategy (Flowpack/Flowpack.ElasticSearch.ContentRepositoryAdaptor#245) My problem was the missing field __dimensionCombinationHash which is expected by the SuggestionMixin. As a result my document-nodes were indexed, but almost emtpy. I solved it by not using the mixin: Took a while to figure it out. I will comment this in the mentioned pull-request, but not having the mixin applied by default would prevent others from that problem. |
This removes the default addition of the AutocompletableMixin and the SuggestableMixin from the package, as well as the analyzer setup done in the settings. Instead the README is amended with instructions on how to use this. This avoids errors when using a custom index name.
|
Finally tackled this and removed the settings in favor of documenting their use. Please (re-)review, @daniellienert and @kitsunet. |
|
Ping… |
See #38 for the problem this "solves" (for the time being.)