Skip to content

FEATURE: Make enabling autocomplete / suggestions configurable #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniellienert merged 1 commit into from
Jan 18, 2021
Merged

FEATURE: Make enabling autocomplete / suggestions configurable #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Classes/Controller/SuggestController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,10 @@ protected function buildRequestForTerm(string $term, string $contextNodeIdentifi
->queryFilter('prefix', [
'neos_completion' => $termPlaceholder
])
->limit(0)
->aggregation('autocomplete', [
->limit(0);

if (($this->searchAsYouTypeSettings['autocomplete']['enabled'] ?? false) === true) {
$query->aggregation('autocomplete', [
'terms' => [
'field' => 'neos_completion',
'order' => [
Expand All @@ -139,8 +141,11 @@ protected function buildRequestForTerm(string $term, string $contextNodeIdentifi
'include' => $termPlaceholder . '.*',
'size' => $this->searchAsYouTypeSettings['autocomplete']['size'] ?? 10
]
])
->suggestions('suggestions', [
]);
}

if (($this->searchAsYouTypeSettings['suggestions']['enabled'] ?? false) === true) {
$query->suggestions('suggestions', [
'prefix' => $termPlaceholder,
'completion' => [
'field' => 'neos_suggestion',
Expand All @@ -152,6 +157,7 @@ protected function buildRequestForTerm(string $term, string $contextNodeIdentifi
]
]
]);
}

$request = $query->getRequest()->toArray();

Expand Down
2 changes: 2 additions & 0 deletions Configuration/Settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ Flowpack:
searchAsYouType:
autocomplete:
size: 10
enabled: true
suggestions:
size: 10
enabled: true
sourceFields:
- neos_path
- title