TASK: Use more fine-grained sanitation#60
Merged
daniellienert merged 2 commits intomasterfrom Jun 11, 2021
Merged
Conversation
daniellienert
force-pushed
the
task/change-sanitation
branch
from
8dae46d to
8ecfe2b
Compare
The previously used `[[:^alnum:]]` strips german umlauts and valid characters of other languages which leeds to strange query results. This is more fine grained approach to sanitize the search word based on elasticsearch recommendations.
daniellienert
force-pushed
the
task/change-sanitation
branch
from
8ecfe2b to
0902359
Compare
kdambekalns
approved these changes
Jan 27, 2021
Member
kdambekalns
left a comment
kdambekalns
left a comment
There was a problem hiding this comment.
Looks good.
Only… naming. Wouldn't it be better to have the class named Searchterm and have a sanitize() method on it? 🤷♂️ But that's rather academic, so feel free to ignore it!
Member
|
Shouldn't the utility class take care of the whole process of turning a string into usable pieces without clutter then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previously used
[[:^alnum:]]strips german umlauts and valid characters of other languages which leads to strange query results.This is more fine grained approach to sanitize the search word based on elasticsearch recommendations.