BUGFIX: Add bottom margin for thumbnail view so it doesn't overlap with pagination in link editor/media selection view#258
Conversation
|
Thx, but do you have some hints on your browser and resolution you used, as I cannot reproduce the issue (and fixed it already sometime in the past) |
gradinarufelix
force-pushed
the
bugfix-add-margin-to-thumbnail-view
branch
from
1cb086f to
6f10956
Compare
|
I just checked it again. This happens in combination with https://github.com/sitegeist/Sitegeist.Archaeopteryx when you want to create a link and switch to the "media" tab. |
| display: grid; | ||
| grid-template-columns: repeat(auto-fill, minmax(200px, 1fr)); | ||
| gap: var(--theme-spacing-Full); | ||
| margin-bottom: 4rem; |
There was a problem hiding this comment.
I think the correct place is adding padding-bottom: 41px; when in selectionMode. As the calculation for the height doesn't correctly measure the available size.
|
@Sebobo Good point. I changed it now, please review and merge if it looks good for you :-) I tested in the selection view, there we have no more overlap. And in the media module we don't have an overly tall spacing at the bottom any more. |
…th pagination in link editor/media selection view
Sebobo
force-pushed
the
bugfix-add-margin-to-thumbnail-view
branch
from
88acdcb to
75c728f
Compare
Sebobo
left a comment
Sebobo
left a comment
There was a problem hiding this comment.
Thx, I cleaned up the commits and will release the fix
2 participants
What I did
I added 4rem of margin-bottom to ThumbnailView, because in a selection view the last line of filenames was not readable due to it being hidden behind the pagination.
How I did it
I added 4rem of margin-bottom to ThumbnailView.module.css.