Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/bump.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Deploy API documentation
uses: bump-sh/github-action@v1
with:
Expand All @@ -30,7 +30,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Comment pull request with API diff
uses: bump-sh/github-action@v1
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
-
name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0
-
Expand All @@ -29,9 +29,9 @@ jobs:
password: ${{ secrets.GITHUB_TOKEN }}
-
name: Set up Go
uses: actions/setup-go@v2
uses: actions/setup-go@v4
with:
go-version: 1.18
go-version: 1.20
-
name: Run GoReleaser
uses: goreleaser/goreleaser-action@v2
Expand Down
36 changes: 16 additions & 20 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ on:
tags:
- v*
branches:
- v*
- main
pull_request:

Expand All @@ -11,51 +12,46 @@ jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Install Go
uses: actions/setup-go@v2
uses: actions/setup-go@v4
with:
go-version: 1.18.x
- name: Checkout code
uses: actions/checkout@v2
go-version: '1.20'
- name: Run linters
uses: golangci/golangci-lint-action@v2
uses: golangci/golangci-lint-action@v3
with:
version: v1.45
version: v1.52

test:
strategy:
matrix:
go-version: [ '1.18']
go-version: [ '1.20', '1.19', '1.18']
platform: [ 'ubuntu-latest' ]
runs-on: ${{ matrix.platform }}
steps:
- uses: actions/checkout@v3
- name: Install Go
if: success()
uses: actions/setup-go@v2
uses: actions/setup-go@v4
with:
go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v2
- name: Run tests
run: go test -v -race ./...

coverage:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Install Go
if: success()
uses: actions/setup-go@v2
uses: actions/setup-go@v4
with:
go-version: 1.18.x
go-version: '1.20'
- name: Checkout code
uses: actions/checkout@v2
- name: Calc coverage
run: |
go test -v -covermode=count -coverprofile=coverage.out .
- name: Convert coverage.out to coverage.lcov
uses: jandelgado/gcov2lcov-action@v1.0.6
- name: Coveralls
uses: coverallsapp/github-action@v1.1.2
with:
github-token: ${{ secrets.github_token }}
path-to-lcov: coverage.lcov
go test -cover ./... -coverpkg=github.com/Flowpack/prunner/... -coverprofile=coverage.txt
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
8 changes: 6 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<img src="docs/prunner-logo-light.png" width="320" align="center">
<img src="docs/prunner-logo-light.png" alt="prunner" width="320" align="center">

[![GoDoc](https://godoc.org/github.com/Flowpack/prunner?status.svg)](https://godoc.org/github.com/Flowpack/prunner)
[![Build Status](https://github.com/Flowpack/prunner/workflows/Go/badge.svg)](https://github.com/Flowpack/prunner/actions?workflow=run%20tests)
[![Go Report Card](https://goreportcard.com/badge/github.com/Flowpack/prunner)](https://goreportcard.com/report/github.com/Flowpack/prunner)

---

Expand Down Expand Up @@ -390,7 +394,7 @@ Prunner can be started inside a container. There are a few things to consider:
clients to generate correct JWT tokens based on the secret.
* Alternatively a pre-generated secret can be passed via the `PRUNNER_JWT_SECRET` env var
and shared with applications accessing the API.
* The `--address` flag should be set to listen on all interfaces (.e.g. `:9009`) or a specific network address.
* The `--address` flag should be set to listen on all interfaces (.e.g. `:9009`) or a specific network address.
This allows to access the API from outside the container.

## Development
Expand Down
1 change: 1 addition & 0 deletions definition/pipelines.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ func (d PipelineDef) Equals(otherDef PipelineDef) bool {
return false
}
}
//nolint:gosimple // Keep the code structure with an explicit if for readability
if d.SourcePath != otherDef.SourcePath {
return false
}
Expand Down