BUGFIX: Use ContentCacheFlusher Aspect for banning varnish pages

[paxuclus]

The cache tags of the Neos ContentCacheFlusher are now used instead
of the manually generated ones from the ContentCacheFlusherService

Resolves #55

todo:

• Mark ContentCacheFlusher as deprecated

[paxuclus]

@daniellienert can you please open a 4.0 branch from b431dbb so I can target this against that? Since the package was moved to the flowpack namespace I don't have maintain permissions anymore.

[daniellienert]

Namespace needs to be adjusted.

[paxuclus]

@daniellienert the package is still in the MOC\Varnish namespace in 4.0. I'd like to release a 4.1.1 with this bugfix since Neos 5.X is still supported.

This patch will need to be upmerged to master later for Neos 7.X compatibility.

What do you think?

[daniellienert]

You are so right ... ☺️

[dlubitz]

@paxuclus @daniellienert I try to prepare a Neos 9 compatible version of this package and stubled over this PR. While I tried to remove the deprecated Flowpack\Varnish\Service\ContentCacheFlusherService I noticed yet another usage of this service:

varnish/Classes/Controller/VarnishCacheController.php

Lines 130 to 135 in a05b8ae

	public function purgeCacheAction(Node $node): void
	{
	$service = new ContentCacheFlusherService();
	$service->flushForNode($node);
	$this->view->assign('value', true);
	}

Not sure if your change made this feature obsolete or if it is still needed to invalidate individual nodes in the backend module?

I know it's quite a long time, but maybe you remember what was the plan here? Thank you

[paxuclus]

Hi @dlubitz,

I'm pretty sure the ContentCacheFlusherService is still needed for the backend module to work as expected. I guess the deprecation annotation is invalid then.

[dlubitz]

I see, thank you for the quick reply.

[daniellienert]

Had a quick look, I also found the usage which @dlubitz mentions