fix: remove coveralls upload #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Stephens <pat@fluent.do>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to remove coveralls output format to prevent gcov failures but unfortunately left in the attempt to upload it which will always warn so tidying that up.
Also adding badge and readme updates.
Summary by cubic
Stop uploading the Coveralls artifact in the unit-tests workflow to remove errors/warnings from gcovr’s Coveralls format. Docs updated to exclude Coveralls from listed coverage formats, add a Coveralls badge in workflows README, and note the GPG key in README.
Risk: 5
Written for commit 4921948. Summary will update automatically on new commits.