[147] label tree

[DrEverr]

Newer iteration to prior #176

[netlify]

✅ Deploy Preview for graypaper-reader ready!

Name	Link
🔨 Latest commit	f303e3c
🔍 Latest deploy log	https://app.netlify.com/sites/graypaper-reader/deploys/67d9ece54324350008b849ef
😎 Deploy Preview	https://deploy-preview-196--graypaper-reader.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[DrEverr]

focused less on display, more on functionality

[tomusdrw]

Looks pretty good!

What I'm still missing is adding the source as a prefix to all labels (to be able to easily disable all local or remote labels at once).

[DrEverr]

Looks pretty good!

What I'm still missing is adding the source as a prefix to all labels (to be able to easily disable all local or remote labels at once).

I still believe it's better not to add the local/ prefix by default. This provides more control and keeps the existing behavior intact. If everything starts with local/ and we switch from hasAllLabels to a hasSomeLabels logic, it essentially makes it impossible to hide any notes. You'd always have to disable local, which would disable all the notes.

[tomusdrw]

Looks pretty good!
What I'm still missing is adding the source as a prefix to all labels (to be able to easily disable all local or remote labels at once).

I still believe it's better not to add the local/ prefix by default. This provides more control and keeps the existing behavior intact. If everything starts with local/ and we switch from hasAllLabels to a hasSomeLabels logic, it essentially makes it impossible to hide any notes. You'd always have to disable local, which would disable all the notes.

No, that's incorrect. local/ and remote/ prefix is added depending on the source of the note. Existing labels have nothing to do with it and should not be modified to include the prefix. It's purely a display thing.

Example:

1. In local storage:
   Note1(labels=x/a, c), Note2(labels=x/b, d), Note3(labels=local)
2. In remote source:
   Note4(labels=x/a, c), Note5(labels=x/b, d), Note6(labels=local).

If we load notes from both sources we should get the following labels tree structure:

local
  local/x
     local/x/a, local/x/b
  local/c
  local/d
  local/local
remote
  remote/x
   remote/x/a, remote/x/b
  remote/c
  remote/d
  remote/local

1. If I want to disable all local labels, I just click local top-level-meta-label.
2. If I want to hide Note3 I need to have local/local inactive
3. If I want to hide Note6 I need to have remote/local inactive
4. If I want to hide Note2 I need to have local/d AND local/x/b inactive (or the entire local/x obviously).

[tomusdrw]

Yes! I think it works as I expected now, if you could add the source prefix to the labels displayed next to notes it would be great (i.e. on top I see local/abc, yet under the note it's just abc).

Other than that I think it's good, thank you for bearing with me :)

[DrEverr]

I've made the last changes you suggested. Should I now focus on displaying labels as a tree, or are we leaving that for the designer?

[DrEverr]

IMO it's ready for merge. @tomusdrw WDYT?