Conversation
The new split-screen and narrow-screen snapshot tests were missing Linux reference PNGs (only macOS snapshots existed), causing all 32 tests to fail on CI with "snapshot doesn't exist" errors. - Generate Linux snapshot PNGs for split-screen and narrow-screen tests - Fix CI workflow to commit snapshots for all test files, not just basic-snapshots - Add global maxDiffPixelRatio (2%) and animations: disabled to handle PDF rendering non-determinism between runs - Add docker-compose build target to skip unneeded development stage Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The new split-screen and narrow-screen snapshot tests were missing Linux reference PNGs (only macOS snapshots existed), causing all 32 tests to fail on CI with "snapshot doesn't exist" errors. - Generate Linux snapshot PNGs for split-screen and narrow-screen tests - Fix CI workflow to commit snapshots for all test files, not just basic-snapshots - Add global maxDiffPixelRatio (2%) and animations: disabled to handle PDF rendering non-determinism between runs - Add docker-compose build target to skip unneeded development stage - Exclude test-results from Biome checks Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for graypaper-reader ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (18)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR updates the snapshot testing infrastructure by broadening artifact coverage patterns in the CI workflow, configuring Playwright screenshot comparison tolerances and animation settings, and refactoring test files to use shared screenshot option constants. Configuration files are updated to exclude test results from version control and linting. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Visual Regression Test Report ✅ PassedGithub run id: 23740502952 🔗 Artifacts: Download |
This was referenced Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Tests
Chores