-
Notifications
You must be signed in to change notification settings - Fork 3
update dependencies #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #453
Conversation
✅ Deploy Preview for pvm-debugger ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughMajor dependency upgrades: React 18→19, Tailwind 3→4, Zod 3→4. Updated associated type declarations and API calls. Component prop types broadened from JSX.Element to ReactNode. CSS refactored from Tailwind Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50–75 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
package.json (1)
74-87: Replace @tailwind directives with @import statement and verify space utility layouts in Tailwind 4.In Tailwind CSS v4, the @tailwind directives (base, components, utilities) are removed and replaced with a single @import "tailwindcss" statement. This is found in
src/globals.csslines 3-5 and must be updated.Additionally, space utility selectors have changed in Tailwind 4 from applying margins to the top of every sibling except the first, to applying margins to the bottom of every sibling except the last. This change affects combinations like space-y with labels and inputs used in shadcn/ui patterns. The following files contain space utilities that may experience layout regressions and should be tested:
src/components/ui/dialog.tsx(space-y-1.5, space-x-2)src/components/ui/card.tsx(space-y-1.5)src/components/NumeralSystemSwitch/index.tsx(space-x-2)src/components/MemoryPreview/MemoryRangesRow.tsx(space-y-1)src/components/ProgramEdit/index.tsx(space-x-2)src/components/ProgramLoader/ProgramFileUpload.tsx(space-x-6, space-x-2)Use the automated upgrade tool (npx @tailwindcss/upgrade@next) to handle most migration changes.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (8)
AGENTS.md(2 hunks)package.json(4 hunks)postcss.config.js(1 hunks)src/components/MemoryPreview/MemoryRangesRow.tsx(4 hunks)src/components/ProgramEdit/index.tsx(1 hunks)src/components/ProgramLoader/loadingUtils.ts(3 hunks)src/globals.css(1 hunks)src/packages/ui-kit/Header/index.tsx(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
src/packages/ui-kit/Header/index.tsx (1)
src/components/Header/index.tsx (1)
Header(101-103)
src/components/ProgramLoader/loadingUtils.ts (1)
src/components/ProgramLoader/types.ts (1)
ProgramUploadFileInput(12-37)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (11)
postcss.config.js (1)
1-6: LGTM! Correct migration to Tailwind 4 PostCSS plugin syntax.The shift from object-based to array-based plugin configuration aligns with Tailwind 4's requirements. The imports are correctly added and the plugins are instantiated as functions.
src/packages/ui-kit/Header/index.tsx (1)
15-17: LGTM! Improved prop typing with ReactNode.Broadening the
endSlotprop fromJSX.ElementtoReactNodeprovides better flexibility and aligns with React 19 best practices. The change is backwards compatible with existing usage.src/components/ProgramEdit/index.tsx (1)
9-11: LGTM! Consistent prop typing improvement.The
startSlotprop type change fromJSX.ElementtoReactNodemirrors the pattern in Header component and provides better type flexibility. This aligns with React 19 conventions.src/globals.css (1)
95-101: LGTM! Correct migration away from @apply directives.Replacing Tailwind's
@applywith explicit CSS values using CSS variables is required for Tailwind 4. Thehsl(var(--variable))pattern correctly applies the theme tokens, and the font family declaration is properly structured.src/components/MemoryPreview/MemoryRangesRow.tsx (2)
67-92: LGTM! Improved ref composition for React 19 compatibility.The refactoring from chained refs (
ref(drop(node))) to aconnectRefscallback is a cleaner pattern that works better with React 19's ref handling. The explicit separation ofdragRefanddropRef, combined with the conditional attachment logic, makes the code more maintainable and avoids potential ref conflicts.
125-125: LGTM! Card ref correctly uses the new callback pattern.The Card component now uses
ref={connectRefs}which properly integrates the drag-and-drop functionality through the new ref composition approach.src/components/ProgramLoader/loadingUtils.ts (3)
4-10: LGTM! Correct Zod 4 type migration.The import changes from
SafeParseReturnTypetoZodSafeParseResultand the addition ofZodIssuealign with Zod 4's updated API. TheValidationResulttype is correctly updated to use the new type.
24-24: LGTM! Explicit schema typing improves type safety.Adding the explicit type annotation
z.ZodType<ProgramUploadFileInput>ensures the schema structure matches the expected type, providing better type checking and IDE support.
143-146: LGTM! Correct Zod 4 error handling update.The change from
result.error.errorstoresult.error.issuesis required for Zod 4. TheZodIssuetype annotation on theerrparameter provides proper typing for the error mapping function.AGENTS.md (1)
1-26: LGTM! Documentation updates align with project changes.The documentation cleanly reflects the current project structure and development workflow. The minor formatting adjustments improve readability without changing the core guidance.
package.json (1)
59-59: Zod v4 compatibility verified—no breaking changes detected.The codebase is already fully compatible with Zod v4.1.13. The only Zod usage is in
src/components/ProgramLoader/loadingUtils.ts, which correctly uses:
ZodSafeParseResulttype (correct for v4).safeParse()validation.error.issuesfor error handling (the correct pattern in v4, not the deprecated.error.errors)None of the common breaking changes from Zod v3→v4 were found in the codebase. The upgrade is safe.
No description provided.