-
Notifications
You must be signed in to change notification settings - Fork 0
Fix commit message for automated version bump. #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe workflow file .github/workflows/bump-version.yml was updated to pass a new commit-message input to the peter-evans/create-pull-request@v5 action in the "Create Pull Request" step. No other steps, logic, or control flow were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/bump-version.yml (1)
98-98: Good improvement; consider conventional commit style.Your change is correct and supported by peter-evans/create-pull-request. Optionally, align with Conventional Commits for cleaner automation downstream.
Apply this diff if you want to switch to conventional wording:
- commit-message: "Bump version to v${{ steps.version.outputs.version }}" + commit-message: "chore(release): bump version to v${{ steps.version.outputs.version }}"
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/bump-version.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: run (22.x)
- GitHub Check: state_transition (22.x)
- GitHub Check: run (22.x)
- GitHub Check: e2e (22.x)
- GitHub Check: run (22.x)
- GitHub Check: test (22.x)
🔇 Additional comments (1)
.github/workflows/bump-version.yml (1)
98-98: commit-message input supported in v5
Verified in the action docs (default: "[create-pull-request] automated change"). No changes required.
View all
Benchmarks summary: 63/63 OK ✅ |
The current commit message was pretty meaningless.