Skip to content

Conversation

@tomusdrw
Copy link
Contributor

The current commit message was pretty meaningless.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Automated version-bump pull requests now include clear, customized commit messages, improving release notes readability and PR review clarity.
    • Standardizes commit messages for automated releases, aiding auditing and traceability across releases.
    • No user-facing functionality is changed; this affects only the release process.
    • Build and runtime behavior remain unchanged.
    • No configuration or updates required from users.

Walkthrough

The workflow file .github/workflows/bump-version.yml was updated to pass a new commit-message input to the peter-evans/create-pull-request@v5 action in the "Create Pull Request" step. No other steps, logic, or control flow were modified.

Changes

Cohort / File(s) Summary
Workflow update
.github/workflows/bump-version.yml
Added commit-message input to peter-evans/create-pull-request@v5 in the "Create Pull Request" step to set a custom commit message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nudge the version, hop by hop,
A tidy note atop the PR crop.
With custom words, I sign my name—
Commit-message set, all the same.
Thump-thump! says QA, looks just right—
Carrot-approved, we merge tonight. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely summarizes the main change of adding a custom commit message for the automated version bump step, making it directly relevant to the changeset without superfluous details.
Description Check ✅ Passed The description explains that the existing commit message lacked clarity and ties directly to the change of updating the automated version bump message, so it is on-topic for the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/bump-version.yml (1)

98-98: Good improvement; consider conventional commit style.

Your change is correct and supported by peter-evans/create-pull-request. Optionally, align with Conventional Commits for cleaner automation downstream.

Apply this diff if you want to switch to conventional wording:

-        commit-message: "Bump version to v${{ steps.version.outputs.version }}"
+        commit-message: "chore(release): bump version to v${{ steps.version.outputs.version }}"
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e48de40 and b66111b.

📒 Files selected for processing (1)
  • .github/workflows/bump-version.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: run (22.x)
  • GitHub Check: state_transition (22.x)
  • GitHub Check: run (22.x)
  • GitHub Check: e2e (22.x)
  • GitHub Check: run (22.x)
  • GitHub Check: test (22.x)
🔇 Additional comments (1)
.github/workflows/bump-version.yml (1)

98-98: commit-message input supported in v5
Verified in the action docs (default: "[create-pull-request] automated change"). No changes required.

@mateuszsikora mateuszsikora enabled auto-merge (squash) September 24, 2025 20:23
@mateuszsikora mateuszsikora merged commit 8c85275 into main Sep 24, 2025
15 checks passed
@mateuszsikora mateuszsikora deleted the td-bump-fix branch September 24, 2025 20:30
@github-actions
Copy link

View all
File Benchmark Ops
bytes/hex-from.ts[0] parse hex using Number with NaN checking 141181.57 ±0.38% 84.1% slower
bytes/hex-from.ts[1] parse hex from char codes 887801.31 ±0.36% fastest ✅
bytes/hex-from.ts[2] parse hex from string nibbles 533828.97 ±3.09% 39.87% slower
math/add_one_overflow.ts[0] add and take modulus 249422922.83 ±6.4% fastest ✅
math/add_one_overflow.ts[1] condition before calculation 223836577.51 ±8.2% 10.26% slower
math/count-bits-u64.ts[0] standard method 8218945.67 ±0.42% 90.66% slower
math/count-bits-u64.ts[1] magic 87992401.74 ±3.94% fastest ✅
math/mul_overflow.ts[0] multiply and bring back to u32 253467543.8 ±6.4% fastest ✅
math/mul_overflow.ts[1] multiply and take modulus 249680455.09 ±6.18% 1.49% slower
math/switch.ts[0] switch 257777518.63 ±6.72% 0.69% slower
math/switch.ts[1] if 259579564.96 ±6.4% fastest ✅
math/count-bits-u32.ts[0] standard method 72411649.51 ±1.69% 68.89% slower
math/count-bits-u32.ts[1] magic 232743507.59 ±6.26% fastest ✅
codec/bigint.decode.ts[0] decode custom 170434653.91 ±2.4% fastest ✅
codec/bigint.decode.ts[1] decode bigint 103402166.25 ±2.31% 39.33% slower
codec/decoding.ts[0] manual decode 22076818.32 ±1.02% 85.1% slower
codec/decoding.ts[1] int32array decode 148200840.77 ±4.16% fastest ✅
codec/decoding.ts[2] dataview decode 148029386.67 ±3.78% 0.12% slower
codec/encoding.ts[0] manual encode 2645570.9 ±0.87% 17.6% slower
codec/encoding.ts[1] int32array encode 3202340.07 ±0.77% 0.25% slower
codec/encoding.ts[2] dataview encode 3210498.29 ±0.62% fastest ✅
hash/index.ts[0] hash with numeric representation 175.05 ±0.72% 28.2% slower
hash/index.ts[1] hash with string representation 110.4 ±0.75% 54.72% slower
hash/index.ts[2] hash with symbol representation 163.5 ±1.41% 32.94% slower
hash/index.ts[3] hash with uint8 representation 148.88 ±1.02% 38.94% slower
hash/index.ts[4] hash with packed representation 243.81 ±1% fastest ✅
hash/index.ts[5] hash with bigint representation 176.12 ±1.29% 27.76% slower
hash/index.ts[6] hash with uint32 representation 151.79 ±4.91% 37.74% slower
codec/bigint.compare.ts[0] compare custom 237942804.45 ±6.5% 2.23% slower
codec/bigint.compare.ts[1] compare bigint 243378923.4 ±6.22% fastest ✅
collections/map-set.ts[0] 2 gets + conditional set 113856.04 ±1.07% fastest ✅
collections/map-set.ts[1] 1 get 1 set 60029.75 ±0.43% 47.28% slower
bytes/hex-to.ts[0] number toString + padding 309144.66 ±0.85% fastest ✅
bytes/hex-to.ts[1] manual 14150.91 ±2.01% 95.42% slower
logger/index.ts[0] console.log with string concat 6375350.91 ±55.56% fastest ✅
logger/index.ts[1] console.log with args 1398451.54 ±113.36% 78.06% slower
codec/view_vs_collection.ts[0] Get first element from Decoded 30764.17 ±1.3% 54.52% slower
codec/view_vs_collection.ts[1] Get first element from View 67637.45 ±1.16% fastest ✅
codec/view_vs_collection.ts[2] Get 50th element from Decoded 29717.72 ±1.85% 56.06% slower
codec/view_vs_collection.ts[3] Get 50th element from View 37115.41 ±1.68% 45.13% slower
codec/view_vs_collection.ts[4] Get last element from Decoded 29202.92 ±2.28% 56.82% slower
codec/view_vs_collection.ts[5] Get last element from View 22718.82 ±3.09% 66.41% slower
codec/view_vs_object.ts[0] Get the first field from Decoded 446973.97 ±2.2% fastest ✅
codec/view_vs_object.ts[1] Get the first field from View 94876.25 ±1.31% 78.77% slower
codec/view_vs_object.ts[2] Get the first field as view from View 98834.53 ±1.16% 77.89% slower
codec/view_vs_object.ts[3] Get two fields from Decoded 438188.17 ±2.03% 1.97% slower
codec/view_vs_object.ts[4] Get two fields from View 66462.18 ±0.56% 85.13% slower
codec/view_vs_object.ts[5] Get two fields from materialized from View 142642.34 ±1.37% 68.09% slower
codec/view_vs_object.ts[6] Get two fields as views from View 70008.55 ±1.69% 84.34% slower
codec/view_vs_object.ts[7] Get only third field from Decoded 433274.28 ±1.53% 3.06% slower
codec/view_vs_object.ts[8] Get only third field from View 93547.52 ±1.94% 79.07% slower
codec/view_vs_object.ts[9] Get only third field as view from View 83037 ±1.34% 81.42% slower
bytes/compare.ts[0] Comparing Uint32 bytes 16287.66 ±2.57% 18.96% slower
bytes/compare.ts[1] Comparing raw bytes 20099.41 ±2.89% fastest ✅
hash/blake2b.ts[0] hasher with simple allocator 0.04 ±1.18% 20% slower
hash/blake2b.ts[1] hasher with page allocator 0.05 ±0.62% fastest ✅
collections/map_vs_sorted.ts[0] Map 326389.31 ±0.31% fastest ✅
collections/map_vs_sorted.ts[1] Map-array 102464.69 ±0.35% 68.61% slower
collections/map_vs_sorted.ts[2] Array 65899.37 ±1.39% 79.81% slower
collections/map_vs_sorted.ts[3] SortedArray 197013.25 ±0.4% 39.64% slower
crypto/ed25519.ts[0] native crypto 8.2 ±0.65% 72.57% slower
crypto/ed25519.ts[1] wasm lib 10.55 ±0.59% 64.7% slower
crypto/ed25519.ts[2] wasm lib batch 29.89 ±0.7% fastest ✅

Benchmarks summary: 63/63 OK ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants