Skip to content

Conversation

@DrEverr
Copy link
Member

@DrEverr DrEverr commented Nov 4, 2025

TRACE [host-calls] INFO(1809622606, off: 56, len: 8) <- 0x0000000000000000
shopuld be
TRACE [host-calls] INFO(1809622606, off: 56, len: 8) <- 0x890d000000000000

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated internal test documentation to clarify testing notes.

Note: This release contains no user-facing changes. Internal test infrastructure and documentation have been updated.

Walkthrough

A comment was updated in the test runner configuration file bin/test-runner/w3f-davxy-071.ts to clarify test-running notes for the ignored entry "fuzzy/00000037". No functional behavior, control-flow logic, or error handling was modified. The ignored test entry and its ignore status remain unchanged; only the accompanying documentation was revised for clarity.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • This is a documentation-only change with no functional modifications
  • Review consists of verifying the comment update accurately describes the test entry and provides useful context

Poem

A comment clarified with care,
The fuzzy test still rests right there,
No logic bent, no code askew,
Just words refined to ring so true! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Annotated known problem with 0.7.1 trace' directly relates to the changeset, which updates a comment in the ignore list to clarify a test-running note about a known issue with version 0.7.1 traces.
Description check ✅ Passed The description provides specific context about the trace output discrepancy that motivated the annotation, showing the expected versus actual values in the test case.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch maso-trace-071-explain

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca77d76 and 0bd4f93.

📒 Files selected for processing (1)
  • bin/test-runner/w3f-davxy-071.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.ts

⚙️ CodeRabbit configuration file

**/*.ts: rules from ./CODESTYLE.md should be adhered to.

**/*.ts: Any function whose documentation mention it must not be used in production code,
can be safely used in *.test.ts files. Other usage should be carefuly reviewed
and the comment must explain why it's safe to use there.

**/*.ts: as conversions must not be used. Suggest using tryAs conversion methods.

**/*.ts: Classes with static Codec field must have private constructor and static create method.

**/*.ts: Casting a bigint (or U64) using Number(x) must have an explanation comment why
it is safe.

**/*.ts: When making changes to code with comments containing links (in classes, constants, methods, etc.)
to graypaper.fluffylabs.dev, ensure those links point to the current version for this update.

Files:

  • bin/test-runner/w3f-davxy-071.ts
⏰ Context from checks skipped due to timeout of 120000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: test (22.x)
  • GitHub Check: run (22.x)
  • GitHub Check: e2e (22.x)
  • GitHub Check: run (22.x)
  • GitHub Check: benchmarks (22.x)
  • GitHub Check: run (22.x)
🔇 Additional comments (1)
bin/test-runner/w3f-davxy-071.ts (1)

11-14: Clear documentation of known issue and planned fix.

The added comments effectively document why this test is ignored, including the root cause ("incorrect onTransferMinGas retrieved from Info HC of another service") and the planned remedy ("Running parallel accumulation should fix this test"). This is helpful context for future maintainers.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

View all
File Benchmark Ops
codec/bigint.decode.ts[0] decode custom 172835479.75 ±2.83% fastest ✅
codec/bigint.decode.ts[1] decode bigint 104773938.87 ±2.65% 39.38% slower
codec/encoding.ts[0] manual encode 3367246.96 ±0.34% 17.5% slower
codec/encoding.ts[1] int32array encode 4052593.42 ±0.57% 0.71% slower
codec/encoding.ts[2] dataview encode 4081461.35 ±0.39% fastest ✅
codec/decoding.ts[0] manual decode 23303070.18 ±0.53% 85.57% slower
codec/decoding.ts[1] int32array decode 157266580.86 ±2.98% 2.64% slower
codec/decoding.ts[2] dataview decode 161535611.87 ±3.62% fastest ✅
collections/map-set.ts[0] 2 gets + conditional set 117029.04 ±0.64% fastest ✅
collections/map-set.ts[1] 1 get 1 set 57294.98 ±1.07% 51.04% slower
math/switch.ts[0] switch 251447769.29 ±5.03% fastest ✅
math/switch.ts[1] if 240825560.55 ±5.73% 4.22% slower
hash/index.ts[0] hash with numeric representation 186.62 ±0.35% 28.1% slower
hash/index.ts[1] hash with string representation 116.97 ±0.28% 54.93% slower
hash/index.ts[2] hash with symbol representation 180.85 ±0.14% 30.32% slower
hash/index.ts[3] hash with uint8 representation 160.64 ±0.19% 38.11% slower
hash/index.ts[4] hash with packed representation 259.55 ±0.2% fastest ✅
hash/index.ts[5] hash with bigint representation 189.92 ±0.17% 26.83% slower
hash/index.ts[6] hash with uint32 representation 199.75 ±0.19% 23.04% slower
bytes/hex-from.ts[0] parse hex using Number with NaN checking 133668.34 ±0.24% 84.37% slower
bytes/hex-from.ts[1] parse hex from char codes 855369.36 ±0.21% fastest ✅
bytes/hex-from.ts[2] parse hex from string nibbles 540035.51 ±0.35% 36.87% slower
bytes/hex-to.ts[0] number toString + padding 310162.39 ±0.23% fastest ✅
bytes/hex-to.ts[1] manual 16236.42 ±0.32% 94.77% slower
codec/bigint.compare.ts[0] compare custom 247817669.88 ±6.35% 7.83% slower
codec/bigint.compare.ts[1] compare bigint 268858577.19 ±5.26% fastest ✅
math/add_one_overflow.ts[0] add and take modulus 250451120.15 ±5.63% fastest ✅
math/add_one_overflow.ts[1] condition before calculation 249765039.15 ±6.73% 0.27% slower
math/count-bits-u32.ts[0] standard method 81010598.82 ±1.58% 64.36% slower
math/count-bits-u32.ts[1] magic 227321866.66 ±6.66% fastest ✅
math/count-bits-u64.ts[0] standard method 1724115.84 ±0.3% 85.8% slower
math/count-bits-u64.ts[1] magic 12140365.35 ±0.36% fastest ✅
math/mul_overflow.ts[0] multiply and bring back to u32 260514729.38 ±5.65% fastest ✅
math/mul_overflow.ts[1] multiply and take modulus 259761764.55 ±5.93% 0.29% slower
logger/index.ts[0] console.log with string concat 8611411.33 ±35.64% fastest ✅
logger/index.ts[1] console.log with args 538709.01 ±117.44% 93.74% slower
codec/view_vs_collection.ts[0] Get first element from Decoded 27052.42 ±1.15% 53.6% slower
codec/view_vs_collection.ts[1] Get first element from View 58298.99 ±1.44% fastest ✅
codec/view_vs_collection.ts[2] Get 50th element from Decoded 27536.13 ±1.27% 52.77% slower
codec/view_vs_collection.ts[3] Get 50th element from View 29641.37 ±1.36% 49.16% slower
codec/view_vs_collection.ts[4] Get last element from Decoded 25672.01 ±2.12% 55.96% slower
codec/view_vs_collection.ts[5] Get last element from View 17486.19 ±1.69% 70.01% slower
codec/view_vs_object.ts[0] Get the first field from Decoded 400576.06 ±1.14% 1.21% slower
codec/view_vs_object.ts[1] Get the first field from View 82391.86 ±0.84% 79.68% slower
codec/view_vs_object.ts[2] Get the first field as view from View 82457.31 ±0.9% 79.66% slower
codec/view_vs_object.ts[3] Get two fields from Decoded 405478.51 ±1.4% fastest ✅
codec/view_vs_object.ts[4] Get two fields from View 66475.95 ±1.03% 83.61% slower
codec/view_vs_object.ts[5] Get two fields from materialized from View 137406.23 ±1.15% 66.11% slower
codec/view_vs_object.ts[6] Get two fields as views from View 66636.05 ±1.07% 83.57% slower
codec/view_vs_object.ts[7] Get only third field from Decoded 402285.54 ±1.33% 0.79% slower
codec/view_vs_object.ts[8] Get only third field from View 82015.94 ±0.94% 79.77% slower
codec/view_vs_object.ts[9] Get only third field as view from View 82270.6 ±0.94% 79.71% slower
bytes/compare.ts[0] Comparing Uint32 bytes 16416.67 ±2.73% 4.41% slower
bytes/compare.ts[1] Comparing raw bytes 17173.74 ±2.69% fastest ✅
collections/map_vs_sorted.ts[0] Map 272136.31 ±0.9% fastest ✅
collections/map_vs_sorted.ts[1] Map-array 96279.05 ±0.78% 64.62% slower
collections/map_vs_sorted.ts[2] Array 39403.81 ±4.2% 85.52% slower
collections/map_vs_sorted.ts[3] SortedArray 187189.02 ±0.62% 31.21% slower
hash/blake2b.ts[0] our hasher 2.14 ±1.35% fastest ✅
hash/blake2b.ts[1] blake2b js 0.04 ±0.63% 98.13% slower
crypto/ed25519.ts[0] native crypto 5.6 ±18.57% 81.04% slower
crypto/ed25519.ts[1] wasm lib 10.38 ±0.37% 64.85% slower
crypto/ed25519.ts[2] wasm lib batch 29.53 ±0.75% fastest ✅

Benchmarks summary: 63/63 OK ✅

@tomusdrw tomusdrw merged commit 663eeb1 into main Nov 4, 2025
16 checks passed
@tomusdrw tomusdrw deleted the maso-trace-071-explain branch November 4, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants