Skip to content

Conversation

@tomusdrw
Copy link
Contributor

  • update ignore list
  • update vectors ref

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated test reference configuration value.
    • Added three additional test cases to the conformance test ignore list.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

This pull request updates the test vector reference commit hash in the build script from one value to another, and adds three additional test vector paths to the conformance test ignore list. The changes are configuration and reference management updates with no modifications to control flow or logic.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

These are straightforward reference updates: a single hash replacement and three new entries added to an ignore list. The changes follow established patterns with no logic modifications, making this a quick verification task.

Possibly Related PRs

Suggested Reviewers

  • skoszuta
  • mateuszsikora

Poem

🐰 A hop, skip, and hash update here,
New vectors to test, the path crystal clear!
Three ignores are added with automated cheer,
Reference refreshed—conformance draws near! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update conformance vectors' directly relates to the changeset, which updates test vector references and the ignore list for conformance testing.
Description check ✅ Passed The description accurately outlines the two main changes: updating the ignore list and updating the vectors reference, both of which are present in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch td-conformance

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 945762b and 503ee37.

📒 Files selected for processing (2)
  • .github/scripts/load-test-ref.sh (1 hunks)
  • bin/test-runner/jam-conformance-071.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.ts

⚙️ CodeRabbit configuration file

**/*.ts: rules from ./CODESTYLE.md should be adhered to.

**/*.ts: Any function whose documentation mention it must not be used in production code,
can be safely used in *.test.ts files. Other usage should be carefuly reviewed
and the comment must explain why it's safe to use there.

**/*.ts: as conversions must not be used. Suggest using tryAs conversion methods.

**/*.ts: Classes with static Codec field must have private constructor and static create method.

**/*.ts: Casting a bigint (or U64) using Number(x) must have an explanation comment why
it is safe.

**/*.ts: When making changes to code with comments containing links (in classes, constants, methods, etc.)
to graypaper.fluffylabs.dev, ensure those links point to the current version for this update.

Files:

  • bin/test-runner/jam-conformance-071.ts
⏰ Context from checks skipped due to timeout of 120000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: e2e (22.x)
  • GitHub Check: run (22.x)
  • GitHub Check: run (22.x)
  • GitHub Check: benchmarks (22.x)
  • GitHub Check: run (22.x)
  • GitHub Check: test (22.x)
🔇 Additional comments (2)
bin/test-runner/jam-conformance-071.ts (2)

13-13: LGTM! Additional test case ignored for valid edge case behavior.

This test is appropriately grouped under the "no timeslot in pre-state - valid behavior" category, consistent with the existing pattern.


19-20: LGTM! Additional test cases ignored for valid edge case behavior.

These tests are appropriately grouped under the "Invalid ticket attempt - valid behavior" category, consistent with the existing pattern.

@github-actions
Copy link

View all
File Benchmark Ops
bytes/hex-from.ts[0] parse hex using Number with NaN checking 122163.22 ±0.48% 85.4% slower
bytes/hex-from.ts[1] parse hex from char codes 836925.2 ±0.49% fastest ✅
bytes/hex-from.ts[2] parse hex from string nibbles 513615.7 ±1.18% 38.63% slower
hash/index.ts[0] hash with numeric representation 183.1 ±0.79% 29.15% slower
hash/index.ts[1] hash with string representation 115.42 ±0.87% 55.34% slower
hash/index.ts[2] hash with symbol representation 179.37 ±1.1% 30.6% slower
hash/index.ts[3] hash with uint8 representation 161.78 ±0.22% 37.4% slower
hash/index.ts[4] hash with packed representation 258.45 ±0.46% fastest ✅
hash/index.ts[5] hash with bigint representation 191.57 ±0.17% 25.88% slower
hash/index.ts[6] hash with uint32 representation 199.58 ±0.37% 22.78% slower
logger/index.ts[0] console.log with string concat 8028369.29 ±36.92% fastest ✅
logger/index.ts[1] console.log with args 49803.43 ±49.27% 99.38% slower
math/add_one_overflow.ts[0] add and take modulus 267344285.12 ±3.97% fastest ✅
math/add_one_overflow.ts[1] condition before calculation 239551018.16 ±7.71% 10.4% slower
bytes/hex-to.ts[0] number toString + padding 207389.04 ±0.79% fastest ✅
bytes/hex-to.ts[1] manual 12049.44 ±0.56% 94.19% slower
codec/encoding.ts[0] manual encode 2186401.49 ±0.3% 22.72% slower
codec/encoding.ts[1] int32array encode 2829138.54 ±1.11% fastest ✅
codec/encoding.ts[2] dataview encode 2800967.9 ±0.53% 1% slower
codec/bigint.compare.ts[0] compare custom 263570709.64 ±5.48% 2.25% slower
codec/bigint.compare.ts[1] compare bigint 269639961.87 ±5.11% fastest ✅
codec/bigint.decode.ts[0] decode custom 172898581.73 ±2.8% fastest ✅
codec/bigint.decode.ts[1] decode bigint 79588054.98 ±3.28% 53.97% slower
codec/decoding.ts[0] manual decode 16905028.85 ±0.45% 89.76% slower
codec/decoding.ts[1] int32array decode 165098741.45 ±3.26% fastest ✅
codec/decoding.ts[2] dataview decode 164728660.69 ±3.27% 0.22% slower
collections/map-set.ts[0] 2 gets + conditional set 119244.47 ±0.13% fastest ✅
collections/map-set.ts[1] 1 get 1 set 61783.71 ±0.01% 48.19% slower
math/count-bits-u64.ts[0] standard method 5107556.76 ±0.24% 89.6% slower
math/count-bits-u64.ts[1] magic 49126694.17 ±60.54% fastest ✅
math/mul_overflow.ts[0] multiply and bring back to u32 259086937.17 ±6.89% 4.31% slower
math/mul_overflow.ts[1] multiply and take modulus 270763565.69 ±5.43% fastest ✅
math/switch.ts[0] switch 266829789.68 ±5.86% fastest ✅
math/switch.ts[1] if 265461754.62 ±4.74% 0.51% slower
math/count-bits-u32.ts[0] standard method 104050907.52 ±2.02% 58.92% slower
math/count-bits-u32.ts[1] magic 253296225.58 ±4.85% fastest ✅
codec/view_vs_object.ts[0] Get the first field from Decoded 514165.34 ±0.43% 0.2% slower
codec/view_vs_object.ts[1] Get the first field from View 103776.66 ±0.13% 79.86% slower
codec/view_vs_object.ts[2] Get the first field as view from View 103726.62 ±0.09% 79.87% slower
codec/view_vs_object.ts[3] Get two fields from Decoded 513562.75 ±0.27% 0.32% slower
codec/view_vs_object.ts[4] Get two fields from View 82786.58 ±0.14% 83.93% slower
codec/view_vs_object.ts[5] Get two fields from materialized from View 173846.55 ±0.23% 66.26% slower
codec/view_vs_object.ts[6] Get two fields as views from View 82461.62 ±0.15% 83.99% slower
codec/view_vs_object.ts[7] Get only third field from Decoded 515200.06 ±0.3% fastest ✅
codec/view_vs_object.ts[8] Get only third field from View 102699.84 ±0.17% 80.07% slower
codec/view_vs_object.ts[9] Get only third field as view from View 102406.79 ±0.16% 80.12% slower
codec/view_vs_collection.ts[0] Get first element from Decoded 30741.02 ±0.24% 55.48% slower
codec/view_vs_collection.ts[1] Get first element from View 69046.64 ±0.15% fastest ✅
codec/view_vs_collection.ts[2] Get 50th element from Decoded 31833.51 ±0.26% 53.9% slower
codec/view_vs_collection.ts[3] Get 50th element from View 35731.9 ±0.23% 48.25% slower
codec/view_vs_collection.ts[4] Get last element from Decoded 31846.16 ±0.17% 53.88% slower
codec/view_vs_collection.ts[5] Get last element from View 24441.8 ±0.22% 64.6% slower
collections/hash-dict-vs-blob-dict_delete.ts[0] StringHashDictionary 559.66 ±112.52% 28.28% slower
collections/hash-dict-vs-blob-dict_delete.ts[1] BlobDictionary(1) 687.94 ±152.09% 11.84% slower
collections/hash-dict-vs-blob-dict_delete.ts[2] BlobDictionary(2) 336.66 ±111.5% 56.86% slower
collections/hash-dict-vs-blob-dict_delete.ts[3] BlobDictionary(3) 639.01 ±165.3% 18.11% slower
collections/hash-dict-vs-blob-dict_delete.ts[4] BlobDictionary(4) 448.58 ±122.81% 42.52% slower
collections/hash-dict-vs-blob-dict_delete.ts[5] BlobDictionary(5) 780.36 ±145.65% fastest ✅
collections/hash-dict-vs-blob-dict_get.ts[0] StringHashDictionary 3661.64 ±0.23% 0.09% slower
collections/hash-dict-vs-blob-dict_get.ts[1] BlobDictionary(1) 3665.1 ±0.23% fastest ✅
collections/hash-dict-vs-blob-dict_get.ts[2] BlobDictionary(2) 3662.3 ±0.31% 0.08% slower
collections/hash-dict-vs-blob-dict_get.ts[3] BlobDictionary(3) 3649.45 ±0.26% 0.43% slower
collections/hash-dict-vs-blob-dict_get.ts[4] BlobDictionary(4) 3655.64 ±0.26% 0.26% slower
collections/hash-dict-vs-blob-dict_get.ts[5] BlobDictionary(5) 988.99 ±116.67% 73.02% slower
collections/hash-dict-vs-blob-dict_set.ts[0] StringHashDictionary 362.26 ±93.52% 26.39% slower
collections/hash-dict-vs-blob-dict_set.ts[1] BlobDictionary(1) 462.26 ±114.13% 6.07% slower
collections/hash-dict-vs-blob-dict_set.ts[2] BlobDictionary(2) 479.44 ±109.67% 2.58% slower
collections/hash-dict-vs-blob-dict_set.ts[3] BlobDictionary(3) 479.2 ±108.45% 2.63% slower
collections/hash-dict-vs-blob-dict_set.ts[4] BlobDictionary(4) 492.15 ±111.7% fastest ✅
collections/hash-dict-vs-blob-dict_set.ts[5] BlobDictionary(5) 139.01 ±102.18% 71.75% slower
bytes/bytes-to-number.ts[0] Conversion with bitops 6268.76 ±11.82% 29.67% slower
bytes/bytes-to-number.ts[1] Conversion without bitops 8913.72 ±5.9% fastest ✅
bytes/compare.ts[0] Comparing Uint32 bytes 21304.57 ±0.12% 2.99% slower
bytes/compare.ts[1] Comparing raw bytes 21960.19 ±0.33% fastest ✅
collections/map_vs_sorted.ts[0] Map 327457.69 ±0.2% fastest ✅
collections/map_vs_sorted.ts[1] Map-array 103656.21 ±0.03% 68.35% slower
collections/map_vs_sorted.ts[2] Array 88995.01 ±0.28% 72.82% slower
collections/map_vs_sorted.ts[3] SortedArray 200899.98 ±0.34% 38.65% slower
hash/blake2b.ts[0] our hasher 2.23 ±0.19% fastest ✅
hash/blake2b.ts[1] blake2b js 0.05 ±0.41% 97.76% slower
crypto/ed25519.ts[0] native crypto 5.48 ±17.95% 82.09% slower
crypto/ed25519.ts[1] wasm lib 10.88 ±0.03% 64.44% slower
crypto/ed25519.ts[2] wasm lib batch 30.6 ±0.51% fastest ✅

Benchmarks summary: 83/83 OK ✅

@mateuszsikora mateuszsikora enabled auto-merge (squash) November 20, 2025 08:33
@mateuszsikora mateuszsikora merged commit 8408216 into main Nov 20, 2025
16 checks passed
@mateuszsikora mateuszsikora deleted the td-conformance branch November 20, 2025 08:33
@coderabbitai coderabbitai bot mentioned this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants