-
Notifications
You must be signed in to change notification settings - Fork 0
Update conformance vectors #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tomusdrw
commented
Nov 20, 2025
- update ignore list
- update vectors ref
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis pull request updates the test vector reference commit hash in the build script from one value to another, and adds three additional test vector paths to the conformance test ignore list. The changes are configuration and reference management updates with no modifications to control flow or logic. Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~5 minutes These are straightforward reference updates: a single hash replacement and three new entries added to an ignore list. The changes follow established patterns with no logic modifications, making this a quick verification task. Possibly Related PRs
Suggested Reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/scripts/load-test-ref.sh(1 hunks)bin/test-runner/jam-conformance-071.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.ts
⚙️ CodeRabbit configuration file
**/*.ts: rules from./CODESTYLE.mdshould be adhered to.
**/*.ts: Any function whose documentation mention it must not be used in production code,
can be safely used in*.test.tsfiles. Other usage should be carefuly reviewed
and the comment must explain why it's safe to use there.
**/*.ts:asconversions must not be used. Suggest usingtryAsconversion methods.
**/*.ts: Classes withstatic Codecfield must have private constructor and staticcreatemethod.
**/*.ts: Casting abigint(orU64) usingNumber(x)must have an explanation comment why
it is safe.
**/*.ts: When making changes to code with comments containing links (in classes, constants, methods, etc.)
to graypaper.fluffylabs.dev, ensure those links point to the current version for this update.
Files:
bin/test-runner/jam-conformance-071.ts
⏰ Context from checks skipped due to timeout of 120000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: e2e (22.x)
- GitHub Check: run (22.x)
- GitHub Check: run (22.x)
- GitHub Check: benchmarks (22.x)
- GitHub Check: run (22.x)
- GitHub Check: test (22.x)
🔇 Additional comments (2)
bin/test-runner/jam-conformance-071.ts (2)
13-13: LGTM! Additional test case ignored for valid edge case behavior.This test is appropriately grouped under the "no timeslot in pre-state - valid behavior" category, consistent with the existing pattern.
19-20: LGTM! Additional test cases ignored for valid edge case behavior.These tests are appropriately grouped under the "Invalid ticket attempt - valid behavior" category, consistent with the existing pattern.
View all
Benchmarks summary: 83/83 OK ✅ |