fix: Swift 6 Sendable errors with macOS 26.2 SDK #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Wengg
approved these changes
Jan 3, 2026
Alex-Wengg
added a commit
that referenced
this pull request
Jan 4, 2026
### Why is this change needed? <!-- Explain the motivation for this change. What problem does it solve? --> Fixes build failures with Xcode 16 / macOS 26.2 SDK where AVAudioPCMBuffer captured in AVAudioConverterInputBlock closures triggers Sendable errors. Uses `nonisolated(unsafe)` since the buffers are accessed synchronously by AVAudioConverter's callback and don't cross actor boundaries. ### Problem FluidAudio v0.9.0 fails to build with macOS 26.2 SDK (Xcode 16+) due to strict Swift 6 Sendable checking. The `AVAudioConverterInputBlock` closure captures `AVAudioPCMBuffer` which isn't marked as Sendable. ### Affected Files 1. `AudioConverter.swift:155-165` - `buffer` captured in input block 2. `StreamingAudioSourceFactory.swift:128-155` - `inputBuffer` captured in input block ### Errors ``` error: capture of 'buffer' with non-Sendable type 'AVAudioPCMBuffer' in a '@sendable' closure error: capture of 'inputBuffer' with non-Sendable type 'AVAudioPCMBuffer' in a '@sendable' closure ``` Co-authored-by: Alex <36247722+Alex-Wengg@users.noreply.github.com>
Alex-Wengg
added a commit
that referenced
this pull request
Jan 5, 2026
### Why is this change needed? <!-- Explain the motivation for this change. What problem does it solve? --> Fixes build failures with Xcode 16 / macOS 26.2 SDK where AVAudioPCMBuffer captured in AVAudioConverterInputBlock closures triggers Sendable errors. Uses `nonisolated(unsafe)` since the buffers are accessed synchronously by AVAudioConverter's callback and don't cross actor boundaries. ### Problem FluidAudio v0.9.0 fails to build with macOS 26.2 SDK (Xcode 16+) due to strict Swift 6 Sendable checking. The `AVAudioConverterInputBlock` closure captures `AVAudioPCMBuffer` which isn't marked as Sendable. ### Affected Files 1. `AudioConverter.swift:155-165` - `buffer` captured in input block 2. `StreamingAudioSourceFactory.swift:128-155` - `inputBuffer` captured in input block ### Errors ``` error: capture of 'buffer' with non-Sendable type 'AVAudioPCMBuffer' in a '@sendable' closure error: capture of 'inputBuffer' with non-Sendable type 'AVAudioPCMBuffer' in a '@sendable' closure ``` Co-authored-by: Alex <36247722+Alex-Wengg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
Fixes build failures with Xcode 16 / macOS 26.2 SDK where AVAudioPCMBuffer
captured in AVAudioConverterInputBlock closures triggers Sendable errors.
Uses
nonisolated(unsafe)since the buffers are accessed synchronouslyby AVAudioConverter's callback and don't cross actor boundaries.
Problem
FluidAudio v0.9.0 fails to build with macOS 26.2 SDK (Xcode 16+) due to strict Swift 6 Sendable checking. The
AVAudioConverterInputBlockclosure capturesAVAudioPCMBufferwhich isn't marked as Sendable.Affected Files
AudioConverter.swift:155-165-buffercaptured in input blockStreamingAudioSourceFactory.swift:128-155-inputBuffercaptured in input blockErrors