Fix Float16 build failure in Xcode GUI by adding architecture checks #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add #if arch(arm64) guard around Float16 usage in SortformerModelInference.swift. Float16 is only available on Apple Silicon, not Intel, regardless of macOS version. The existing #available check only guards OS version, not CPU architecture. This causes build failures when archiving macOS apps for distribution (which builds for both arm64 and x86_64 by default). Fixes build error: - 'Float16' is unavailable in macOS - Conformance of 'Float16' to 'MLShapedArrayScalar' is unavailable in macOS
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an architecture guard around the Float16-based Sortformer chunk embedding extraction so that macOS archives targeting x86_64 no longer fail to build. It preserves the existing runtime behavior on supported arm64 platforms while excluding the unsupported Float16 path from Intel builds.
Changes:
- Refactors the chunk-embedding decoding logic to keep the existing Float32 code path as the primary option.
- Wraps the
Float16MLShapedArrayextraction and conversion in an#if arch(arm64)compile-time guard plus an#available(macOS 15.0, iOS 18.0, *)runtime check. - Ensures that on non-arm64 architectures the code consistently throws
SortformerError.inferenceFailed("Missing chunk_pre_encoder_embs_out")rather than attempting to compileFloat16usages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
schmatz
changed the title
schmatz
changed the title
Contributor
|
@schmatz its gonna be a while until we make a release tag as we are cleaning some things up . if that is fine i will merge this pr asap |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #269 for motivation and details.
Add #if arch(arm64) guard around Float16 usage in SortformerModelInference.swift.
Float16 is only available on Apple Silicon, not Intel, regardless of macOS version. The existing #available check only guards OS version, not CPU architecture. This causes build failures when archiving macOS apps for distribution (which builds for both arm64 and x86_64 by default). I tried to work around this with every setting I could find but did not get it working in the GUI (CLI worked.)
Fixes build error:
Why is this change needed?
Allows building Mac apps that use this with the Xcode GUI