Skip to content

Conversation

@wasabeef
Copy link
Member

What does this change?

  • Support unknown mime type files
    Previously, unknown file types were not generated.

What is the value of this and can you measure success?

Pass Tests.

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #56 (e0afb6e) into main (faf4e2b) will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   99.54%   99.31%   -0.23%     
==========================================
  Files          16       16              
  Lines         441      440       -1     
==========================================
- Hits          439      437       -2     
- Misses          2        3       +1     
Impacted Files Coverage Δ
lib/src/generators/assets_generator.dart 100.00% <ø> (ø)
lib/src/settings/asset_type.dart 93.75% <0.00%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf4e2b...e0afb6e. Read the comment docs.

@wasabeef wasabeef added the bug Something isn't working label Nov 23, 2020
@wasabeef wasabeef added this to the 1.3.0 milestone Nov 23, 2020
@wasabeef wasabeef mentioned this pull request Nov 23, 2020
@wasabeef wasabeef requested a review from lcdsmao November 23, 2020 11:27
@wasabeef wasabeef merged commit 69dd134 into main Nov 23, 2020
@wasabeef wasabeef deleted the support-unknown-mime branch November 23, 2020 12:33
@wasabeef wasabeef mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants