ADAM does not accept keyword arguments

[jessebett]

?Flux.ADAM gives the help string ADAM(η = 0.001, β = (0.9, 0.999))

But if you try to create an optimizer with those (unicode) keyword arguments then you get a method error for unexpected arguments.

[MikeInnes]

Unfortunately this is a notation clash between [named] default arguments and keyword arguments. In signatures it's unambiguous because you have to use ; for kwargs, but this doesn't work when you actually call a function.

How about writing the signature as

ADAM(η, β)
ADAM() => ADAM(0.001, (0.9, 0.999))

[jessebett]

Yes I think the help string mislead me to think those were keyword arguments, but you're right that I should have looked for the ;.

[ToucheSir]

Can we call this closed by #904 and subsequent PRs?

[darsnack]

The initial issue is the same, but that's because it is the standard way to document this situation in a docstring. I agree that having to look for ; isn't helpful. I am pushing for only LR as a positional argument in Optimisers.jl (which would make this a non-issue).