Move logic to set a specific pack namespace to its own method.#23
Merged
gap777 merged 1 commit intoFlytedesk:mainfrom Nov 13, 2024
Merged
Conversation
This allows applications to hook into this public method to do any on-demand custom namespacing without duplicating the logic defined in this gem.
Contributor
Author
|
Hey @gap777, would love to hear your thoughts on this one. |
gap777
approved these changes
Nov 13, 2024
Contributor
Author
|
@gap777 Thank you. One thing that I was hoping to get your take on is: |
Collaborator
|
I just merged your PR, as I thought it satisfied your use case.... please open a new one with the changes you're proposing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Applications might want to enforce automatic namespaces based on certain criteria specific to their
package.yml, let's say,version: v2, or any other application-specific property. By exposing a public method to do the namespacing, applications can call this method rather than duplicating the code from this gem.Changes