release(18.6.1): fix label perf (#304) + group position race (#305)#306
Merged
Conversation
When `withReflowOnResize()` is paired with a group that uses `fAutoSizeToFitChildren` and the graph is swapped in (e.g. by replacing the `@for` source), several children of the group could collapse onto a single DOM-measured position. The orchestrator was building its plan from candidates whose `position()` signal had not yet been mirrored into `_position`, so one stale rect propagated as the same shift target to many siblings. `_safeGetRect` now returns `null` when a node's model signal and `_position` mirror are out of sync. The orchestrator skips that candidate for the tick and picks up the node again once the next coherent state arrives. Fixes #305. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
`ConnectionContentLayoutEngine.layout()` runs a tight loop that
computes a position for every `fConnectionContent` and writes its
`style.transform`. The size lookup inside `PolylineContentPlace`
used to call `RectExtensions.fromElement(...)`, which means a
`getBoundingClientRect()` on every iteration. Each read after the
previous iteration's transform write forced the browser to flush
layout — at a few hundred labelled connections this became O(N²)
work and stalled drag.
`IPolylineContent` now exposes a `measureSize()` accessor; the
`FConnectionContentBase` implementation installs a `ResizeObserver`
on its host element once and updates a cached `{width, height}`
asynchronously when the label actually resizes. The placement loop
reads from memory and never touches the DOM.
Trade-off: until the observer delivers its first entry the cache
holds `{0, 0}`, so the edge guard does not push labels away from
path endpoints on the very first frame. Labels at `position` other
than 0 or 1 are unaffected.
Fixes #304.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fConnectionContentno longer readsgetBoundingClientRect()on every redraw. Each label installs aResizeObserveronce and reports its size from a cached value via the newIPolylineContent.measureSize(). The placement loop inPolylineContentPlace.compute()was interleaving DOM reads withstyle.transformwrites per iteration, which forced a synchronous layout flush per label and turned drag at a few hundred labelled connections into O(N²) browser work.withReflowOnResize()is paired withfAutoSizeToFitChildrenon a group and the graph is swapped, candidates whoseposition()signal had not yet been mirrored into_positionused to feed one stale DOM rect to every sibling, collapsing them onto the same fractional point. Such candidates are now skipped for the tick.@foblex/flow,@foblex/flow-dagre-layout,@foblex/flow-elk-layout, and the root workspace to18.6.1; CHANGELOG section pinned under the new release header.Test plan
libs/f-flow/.../connection-content-perf.spec.ts— 30 source-position redraws produce 0getBoundingClientRect()calls on label hosts.libs/f-flow/.../group-children-position-race.spec.ts— small → big graph swap withwithReflowOnResize() + fAutoSizeToFitChildrenkeeps every child at its assigned position.nx test f-flowsuite green (138 + 1 + 1 specs).nx lint f-flowclean.🤖 Generated with Claude Code