Skip to content

refactor: terraform fmt#54

Merged
bzarboni1 merged 2 commits intomainfrom
52-bug-modules-fail-validation-for-aws
Jul 3, 2024
Merged

refactor: terraform fmt#54
bzarboni1 merged 2 commits intomainfrom
52-bug-modules-fail-validation-for-aws

Conversation

@bzarboni1
Copy link
Copy Markdown
Contributor

ISSUE

#52 - [Bug] Modules fail validation for AWS

When running the bootstrap layer for AWS, the following error is encountered:

$ terraform plan
╷
│ Error: Invalid value for variable
│ 
│   on main.tf line 50, in module "github_foundations":
│   50:   oidc_configuration = local.oidc_configuration
│     ├────────────────
│     │ var.oidc_configuration.azure is null
│     │ var.oidc_configuration.custom is null
│     │ var.oidc_configuration.gcp is null
│ 
│ At least one oidc_configuration must be set.
│ 
│ This was checked by the validation rule at
│ .terraform/modules/github_foundations/modules/github-foundations/variables.tf:91,3-13.

The validation does not currently support aws.


ADDITIONALLY

While commiting the fix for the above, the trivy and terraform ftm pre-commit steps failed.
The suggested changes were made to the code.


@bzarboni1 bzarboni1 self-assigned this Jul 3, 2024
@bzarboni1 bzarboni1 requested a review from TylerMizuyabu July 3, 2024 18:47
@bzarboni1 bzarboni1 merged commit 94fad9a into main Jul 3, 2024
@bzarboni1 bzarboni1 deleted the 52-bug-modules-fail-validation-for-aws branch July 3, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants