fix run_name format in tutorial notebooks and add missing dataset/model properties#99
Conversation
…or with outdated processor
There was a problem hiding this comment.
Bug: Sync Issue on Successful Training
The after_train method now only syncs training results and artifacts to the hub when an exception occurs. This is because the sync logic was moved inside the exception handling block (if exc_type is not None). As a result, successful training completion does not trigger the final sync.
focoos/trainer/hooks/sync_to_hub.py#L71-L104
focoos/focoos/trainer/hooks/sync_to_hub.py
Lines 71 to 104 in ed28669
Bug: Refactoring Error: Unhandled `None` in Iteration
The refactored logic in visualizer.py introduces a TypeError: 'NoneType' object is not iterable when the classes argument is None. The new else branch attempts to iterate over classes ([str(i) for i in classes]) when it is None, whereas the original code correctly handled this case by not attempting to process classes if it was None.
focoos/utils/visualizer.py#L489-L493
focoos/focoos/utils/visualizer.py
Lines 489 to 493 in ed28669
BugBot free trial expires on June 12, 2025
Your team has used $0.00 of the $50.00 spend limit so far. Team admins can manage spend limit in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
Minor Fixes
f"{model.name}_{train_dataset.name}"pattern consistentlynameandtaskproperties inMapDatasetclass andnameproperty inFocoosModelclasssync_to_hubparameter and training configuration examples