Support for repeated lyrics on LRC format#86
Merged
nift4 merged 1 commit intoFoedusProgramme:betafrom Feb 16, 2024
Merged
Conversation
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some programs, such as foobar2000's OpenLyrics plugin, have the ability to save "compressed" LRC files, making that if a line on the song is repeated exactly, instead of being added in sequence for the song, a time marker is added to the same previous line on the song.
Previous to this change, for this kind of lines, the lyrics viewer for Gramophone showed it only once, the first time that appeared, along with the secondary markers on display. This makes sure that all lines are now rendered properly.
(Little benchmark with this change, average 5 times same file: before 34ms, after 44ms)