Skip to content

Support []Flaggable flags where multiple uses append to the underlying slice#140

Merged
FollowTheProcess merged 7 commits intomainfrom
feat/slice-flags
Feb 5, 2025
Merged

Support []Flaggable flags where multiple uses append to the underlying slice#140
FollowTheProcess merged 7 commits intomainfrom
feat/slice-flags

Conversation

@FollowTheProcess
Copy link
Copy Markdown
Owner

  • Viable pattern for slice flags
  • Add []int8

Summary

@FollowTheProcess FollowTheProcess added the feature New feature or request label Feb 5, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 82.32759% with 41 lines in your changes missing coverage. Please review.

Project coverage is 90.75%. Comparing base (5e0d86f) to head (a9d81f2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/flag/flag.go 82.32% 29 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   91.88%   90.75%   -1.13%     
==========================================
  Files           6        6              
  Lines        1367     1590     +223     
==========================================
+ Hits         1256     1443     +187     
- Misses         79      103      +24     
- Partials       32       44      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FollowTheProcess FollowTheProcess marked this pull request as ready for review February 5, 2025 16:37
@FollowTheProcess FollowTheProcess merged commit 85179a3 into main Feb 5, 2025
@FollowTheProcess FollowTheProcess deleted the feat/slice-flags branch February 5, 2025 16:38
FollowTheProcess added a commit that referenced this pull request Dec 3, 2025
…ing slice (#140)

* Viable pattern for slice flags

* Add []int8

* Add []int16

* Add []int32 and []int64

* Add all the []uints

* Add a helper for bad type conversion errors

* Add the remaining slice types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant