Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@ jobs:
with:
go-version-file: go.mod

- name: Clean Mod Cache # See https://github.com/golangci/golangci-lint-action/issues/135
run: go clean -modcache

- name: Run Linting
uses: golangci/golangci-lint-action@v6
with:
Expand Down
2 changes: 1 addition & 1 deletion Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ tasks:
msg: nilaway not installed, see https://github.com/uber-go/nilaway
cmds:
- golangci-lint run --fix
- nilaway -include-pkgs="{{.PACKAGE}}" ./...
# - nilaway -include-pkgs="{{.PACKAGE}}" ./... # nilaway doesn't work with go 1.23 yet

docs:
desc: Render the pkg docs locally
Expand Down
2 changes: 2 additions & 0 deletions args.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ func ExactArgs(n int) ArgValidator {

// BetweenArgs is a positional argument validator that allows between min and max arguments (inclusive),
// any outside that range will return an error.
//
//nolint:predeclared // min has same name as min function but we don't use it here and the clarity is worth it
func BetweenArgs(min, max int) ArgValidator {
return func(cmd *Command, args []string) error {
nArgs := len(args)
Expand Down
9 changes: 6 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
module github.com/FollowTheProcess/cli

go 1.22
go 1.23

require github.com/FollowTheProcess/test v0.12.1
require github.com/FollowTheProcess/test v0.14.0

require github.com/google/go-cmp v0.6.0 // indirect
require (
github.com/aymanbagabas/go-udiff v0.2.0 // indirect
github.com/google/go-cmp v0.6.0 // indirect
)
6 changes: 4 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
github.com/FollowTheProcess/test v0.12.1 h1:kgdT9RhuWfWuk9PUj7my08quuZhh0J0Rs10Vozn9/8g=
github.com/FollowTheProcess/test v0.12.1/go.mod h1:oIqlUoS8wKFmKBFBMJH/+asP7lQXE2D3YFhmUEubTUw=
github.com/FollowTheProcess/test v0.14.0 h1:Iegv9JbH8eV8Va/Nw2xaL+feVKEfAFzI5RiBPksNahY=
github.com/FollowTheProcess/test v0.14.0/go.mod h1:WwdigHlEGoXEzt8n/VGpqrNkD3j5gHsqBjYduqTqRE0=
github.com/aymanbagabas/go-udiff v0.2.0 h1:TK0fH4MteXUDspT88n8CKzvK0X9O2xu9yQjWpi6yML8=
github.com/aymanbagabas/go-udiff v0.2.0/go.mod h1:RE4Ex0qsGkTAJoQdQQCA0uG+nAzJO/pI/QwceO5fgrA=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=