Skip to content

Reduce memory allocation in cli.New#96

Merged
FollowTheProcess merged 3 commits intomainfrom
perf/benchmark-new
Sep 22, 2024
Merged

Reduce memory allocation in cli.New#96
FollowTheProcess merged 3 commits intomainfrom
perf/benchmark-new

Conversation

@FollowTheProcess
Copy link
Copy Markdown
Owner

  • Add a benchmark for cli.New
  • Reduce memory allocation in cli.New

Summary

@FollowTheProcess FollowTheProcess added the performance Performance label Sep 22, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (3713af3) to head (3ef3121).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
- Coverage   93.04%   93.02%   -0.03%     
==========================================
  Files           7        7              
  Lines         949      946       -3     
==========================================
- Hits          883      880       -3     
  Misses         39       39              
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FollowTheProcess FollowTheProcess merged commit 9d76e8c into main Sep 22, 2024
@FollowTheProcess FollowTheProcess deleted the perf/benchmark-new branch September 22, 2024 15:27
FollowTheProcess added a commit that referenced this pull request Dec 3, 2025
* Add a benchmark for cli.New

* Reduce memory allocation in cli.New

* Add TODO around the flags maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant