Skip to content

Fix attrs being silently dropped on child loggers#33

Merged
FollowTheProcess merged 2 commits intomainfrom
fix/silently-dropped-attrs
Apr 6, 2026
Merged

Fix attrs being silently dropped on child loggers#33
FollowTheProcess merged 2 commits intomainfrom
fix/silently-dropped-attrs

Conversation

@FollowTheProcess
Copy link
Copy Markdown
Owner

@FollowTheProcess FollowTheProcess commented Apr 6, 2026

Summary

Fix a bug where l.attrs were not copied to a child logger so would be silently dropped

@FollowTheProcess FollowTheProcess added the bug Something isn't working label Apr 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.33%. Comparing base (4c4fc3a) to head (070da80).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
log.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   96.29%   96.33%   +0.03%     
==========================================
  Files           3        3              
  Lines         108      109       +1     
==========================================
+ Hits          104      105       +1     
  Misses          3        3              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FollowTheProcess FollowTheProcess merged commit 008e81f into main Apr 6, 2026
10 of 11 checks passed
@FollowTheProcess FollowTheProcess deleted the fix/silently-dropped-attrs branch April 6, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant