Conversation
jogawebb
left a comment
jogawebb
left a comment
There was a problem hiding this comment.
Overall, these examples look really good. I think we should consider doing the same cleaning up with the API for the TypeScript functions. I think they're helpful examples for anyone who wouldn't want to use the JSX way of doing things.
| move: { id: 10, type: 'to', author: author, date: date }, | ||
| }} | ||
| > | ||
| <MoveRangeStart |
There was a problem hiding this comment.
If we're being picky, these tags can be self-closing. The <MoveRangeStart/> and <MoveRangeEnd/> will never have children.
| await Docx.fromJsx( | ||
| <Section> | ||
| {/* Image MoveTo */} | ||
| <Paragraph |
There was a problem hiding this comment.
The pilcrow move here isn't necessary. It will work, but it also indicates that the whole paragraph has moved, instead of/in addition to the image.
| Paragraph, | ||
| Row, | ||
| Section, | ||
| Table, |
There was a problem hiding this comment.
Check for unused imports. It looks like Table, Row, Cell and Image aren't in this file anymore.
3 participants
Uh oh!
There was an error while loading. Please reload this page.