Merged
Conversation
DrRataplan
suggested changes
Feb 11, 2019
mehmetscoskun
force-pushed
the
has-children
branch
from
2eb1d7a to
9be3a6c
Compare
DrRataplan
approved these changes
Feb 11, 2019
Pull Request Test Coverage Report for Build 814
💛 - Coveralls |
JosVerburg
reviewed
Feb 12, 2019
| return zipSingleton([nodeSequence], ([nodeValue]: (Value | null)[]) => { | ||
| const node: ConcreteNode = nodeValue ? nodeValue.value : null; | ||
|
|
||
| if (node && node.firstChild) { |
Member
There was a problem hiding this comment.
I believe we should use the executionParameters.domFacade to retrieve the child node.
Note: executionParameters is now _executionParameters
@DrRataplan @mehmetscoskun I know the PR is already merged but I think it best if you take a look at this ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.