Clarify documentation on REGISTRY_KEY source#662
Merged
joachimmetz merged 1 commit intoForensicArtifacts:mainfrom Apr 23, 2026
Merged
Clarify documentation on REGISTRY_KEY source#662joachimmetz merged 1 commit intoForensicArtifacts:mainfrom
REGISTRY_KEY source#662joachimmetz merged 1 commit intoForensicArtifacts:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 69.70% 69.33% -0.37%
==========================================
Files 9 9
Lines 769 763 -6
==========================================
- Hits 536 529 -7
- Misses 233 234 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joachimmetz
approved these changes
Apr 23, 2026
Member
joachimmetz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the proposed changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry key contents is quite ambiguous (and means something different from registry value contents), so the wording is clarified after consulting with @joachimmetz.
Furthermore, this also fixes the example that is not consistent with the description of the
keysattribute:I verified on my machine and
HKEY_USERS\*\Software\Microsoft\Internet Explorer\TypedURLsusers contains no subkeys, only values (e.g.url1with contenthttp://go.microsoft.com/fwlink/p/?LinkId=255141). Thus, the glob here will match no key.HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\App Pathsproposed here on the other hand contains multiple subkeys (e.g.chrome.exe,pwsh.exe,mplayer2.exe) which contain values specifying the path (but are not consistent: some do it through the default value, some do it through value namedPath).