feat(flattener): allow users to flatten JSON primitive column by Thenkei · Pull Request #1071 · ForestAdmin/agent-nodejs

Thenkei · 2024-03-14T11:07:17Z

Definition of Done

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

realSpok · 2024-03-14T12:41:46Z

packages/plugin-flattener/src/flatten-column/customization.ts

-export function makeField(columnName: string, path: string, schema: ColumnSchema) {
-  const columnType = getValue({ [columnName]: schema.columnType }, path) as ColumnType;
+export function makeField(columnName: string, path: string, baseColumnType: ColumnType) {
+  const columnType = getValue({ [columnName]: baseColumnType }, path) as ColumnType;


nice ! More understandable

packages/plugin-flattener/src/flatten-json-column/index.ts

realSpok · 2024-03-14T13:15:47Z

packages/plugin-flattener/src/flatten-json-column/index.ts

+  options?: FlattenJsonColumnOptions,
+): Promise<void> {
+  if (!options || !options.columnName) {
+    throw new Error('options.columnName and options.columnType are required.');


Not everyone is on ts sadly :)

packages/plugin-flattener/src/flatten-json-column/index.ts

realSpok · 2024-03-14T13:22:29Z

packages/plugin-flattener/src/flatten-json-column/index.ts

+ * @param options.columnName The name of the column to import.
+ * @param options.columnType The type of the column to import.
+ * @param options.level The maximum level of nested fields to import.
+ * @param options.readonly Should the imported fields be read-only?


we could indicate that it is readonly false by default

How do you imagine this?

realSpok · 2024-03-14T13:23:06Z

packages/plugin-flattener/src/flatten-json-column/index.ts

+    throw new Error('options.columnName and options.columnType are required.');
+  }
+
+  if (!collection) throw new Error('This plugin can only be called when customizing collections.');


shouldn't we also check that dataSource was provided?

There's no dataSource in this case. 🗡️

realSpok · 2024-03-14T13:26:19Z

packages/plugin-flattener/src/flatten-json-column/index.ts

+import flattenColumn from '../flatten-column';
+
+export type FlattenJsonColumnOptions = {
+  columnName: string;


Suggested change

columnName: string;

originColumnName: string;

or

Suggested change

columnName: string;

jsonColumnName: string;

to lift the ambiguity with the targets column names

actually baseColumnName like you used baseColumnType above is perfect

I wanted to keep it close to the original plugin but why not.

realSpok · 2024-03-14T13:28:28Z

packages/plugin-flattener/src/flatten-json-column/index.ts

+ * @param dataSource The dataSource customizer provided by the agent.
+ * @param collection The collection customizer instance provided by the agent.
+ * @param options The options of the plugin.
+ * @param options.columnName The name of the column to import.


Suggested change

* @param options.columnName The name of the column to import.

* @param options.columnName The name of the json column that you want to flatten.

realSpok · 2024-03-14T13:29:39Z

packages/plugin-flattener/src/flatten-json-column/index.ts

+ * @param collection The collection customizer instance provided by the agent.
+ * @param options The options of the plugin.
+ * @param options.columnName The name of the column to import.
+ * @param options.columnType The type of the column to import.


Suggested change

* @param options.columnType The type of the column to import.

* @param options.columnType a json object representing the shape of the data in the json column, with keys the column names, and values either json (to flatten further) or a primitive type (to define a column)

realSpok

✅ Code review
- ✅ Use pure functions when possible
- ✅ Performance concerns
- ✅ Security concerns
- ✅ The PR tackle one subject only
✅ Automatic tests
- ✅ Unit tests
- ⤬ Integration tests
✅ Manual tests
- ✅ Test the functionality
- ✅ Test error cases
✅ PR title
✅ Destination branch
⤬ PR linked to the clickup task

Thenkei

🚀

qlty-cloud-legacy · 2024-03-14T16:33:09Z

Code Climate has analyzed commit 0eb7a4d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.4%.

View more on Code Climate.

# @forestadmin/plugin-flattener [1.1.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.0.93...@forestadmin/plugin-flattener@1.1.0) (2024-03-14) ### Features * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13))

forest-bot · 2024-03-14T16:49:23Z

🎉 This PR is included in version 1.1.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-03-18T09:11:53Z

🎉 This PR is included in version 1.5.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.7.13](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.7.12...example@1.7.13) (2024-03-19) ### Bug Fixes * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) ### Features * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13))

# [1.2.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.1.9...@forestadmin/datasource-replica@1.2.0) (2024-03-19) ### Bug Fixes * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) ### Features * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13))

# [1.10.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.9.5...@forestadmin/datasource-sql@1.10.0) (2024-03-19) ### Bug Fixes * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) ### Features * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13))

forest-bot · 2024-03-19T16:20:49Z

🎉 This PR is included in version 1.7.13 🎉

The release is available on example@1.7.13

Your semantic-release bot 📦🚀

## [1.6.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.6.5...@forestadmin/datasource-mongoose@1.6.6) (2024-03-20) ### Bug Fixes * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) ### Features * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13))

forest-bot · 2024-03-20T15:44:10Z

🎉 This PR is included in version 1.6.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.38.8](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.38.7...@forestadmin/agent@1.38.8) (2024-04-02) ### Bug Fixes * **datasource-mongo:** auto introspection does not work ([#1078](#1078)) ([d32456b](d32456b)) * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * mangodb datasource does not generate introspection ([#1077](#1077)) ([5a06419](5a06419)) * **mongo-datasource:** should return record with empty flattened record ([#1080](#1080)) ([420fbfc](420fbfc)) * **mongo:** introspection of models with more than 30 properties (by default) ([#1088](#1088)) ([c06c064](c06c064)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) * **sql:** fix the type of listCollectionsFromIntrospection to support previous versions of introspection ([#1089](#1089)) ([64604e0](64604e0)) * **sql:** users should be able to use table with multiple sequences ([#1087](#1087)) ([9e8b6eb](9e8b6eb)) ### Features * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **datasource-sql:** add support for views ([#903](#903)) ([1695245](1695245)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13)) * **forest-cloud:** improve a message when there is a 401 http error ([#1081](#1081)) ([358a104](358a104)) * improve error message in case of invalid token ([#1083](#1083)) ([f03d5c7](f03d5c7)) * list collections from an introspection result ([#1086](#1086)) ([2407dc9](2407dc9))

# [1.8.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.7.1...@forestadmin/datasource-sequelize@1.8.0) (2024-04-02) ### Bug Fixes * **datasource-mongo:** auto introspection does not work ([#1078](#1078)) ([d32456b](d32456b)) * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * mangodb datasource does not generate introspection ([#1077](#1077)) ([5a06419](5a06419)) * **mongo-datasource:** should return record with empty flattened record ([#1080](#1080)) ([420fbfc](420fbfc)) * **mongo:** introspection of models with more than 30 properties (by default) ([#1088](#1088)) ([c06c064](c06c064)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) * **sql:** fix the type of listCollectionsFromIntrospection to support previous versions of introspection ([#1089](#1089)) ([64604e0](64604e0)) * **sql:** users should be able to use table with multiple sequences ([#1087](#1087)) ([9e8b6eb](9e8b6eb)) ### Features * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **datasource-sql:** add support for views ([#903](#903)) ([1695245](1695245)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13)) * **forest-cloud:** improve a message when there is a 401 http error ([#1081](#1081)) ([358a104](358a104)) * improve error message in case of invalid token ([#1083](#1083)) ([f03d5c7](f03d5c7)) * list collections from an introspection result ([#1086](#1086)) ([2407dc9](2407dc9))

# [1.26.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.25.12...@forestadmin/forestadmin-client@1.26.0) (2024-04-02) ### Bug Fixes * **datasource-mongo:** auto introspection does not work ([#1078](#1078)) ([d32456b](d32456b)) * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * mangodb datasource does not generate introspection ([#1077](#1077)) ([5a06419](5a06419)) * **mongo-datasource:** should return record with empty flattened record ([#1080](#1080)) ([420fbfc](420fbfc)) * **mongo:** introspection of models with more than 30 properties (by default) ([#1088](#1088)) ([c06c064](c06c064)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) * **sql:** fix the type of listCollectionsFromIntrospection to support previous versions of introspection ([#1089](#1089)) ([64604e0](64604e0)) * **sql:** users should be able to use table with multiple sequences ([#1087](#1087)) ([9e8b6eb](9e8b6eb)) ### Features * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **datasource-sql:** add support for views ([#903](#903)) ([1695245](1695245)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13)) * **forest-cloud:** improve a message when there is a 401 http error ([#1081](#1081)) ([358a104](358a104)) * improve error message in case of invalid token ([#1083](#1083)) ([f03d5c7](f03d5c7)) * list collections from an introspection result ([#1086](#1086)) ([2407dc9](2407dc9))

forest-bot · 2024-04-02T15:10:37Z

🎉 This PR is included in version 1.38.8 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-04-02T15:11:49Z

🎉 This PR is included in version 1.8.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-04-02T15:13:01Z

🎉 This PR is included in version 1.26.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# [1.44.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.43.6...@forestadmin/datasource-customizer@1.44.0) (2024-04-05) ### Bug Fixes * change introspection type to avoid breaking change ([#1095](#1095)) ([42777a0](42777a0)) * **datasource-mongo:** auto introspection does not work ([#1078](#1078)) ([d32456b](d32456b)) * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * introspection format and versions ([#1094](#1094)) ([c11bc31](c11bc31)) * mangodb datasource does not generate introspection ([#1077](#1077)) ([5a06419](5a06419)) * **mongo-datasource:** should return record with empty flattened record ([#1080](#1080)) ([420fbfc](420fbfc)) * **mongo:** introspection of models with more than 30 properties (by default) ([#1088](#1088)) ([c06c064](c06c064)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * replace latesIntrospection to legacyIntrospection ([#1092](#1092)) ([e5e6c73](e5e6c73)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) * **sql:** fix the type of listCollectionsFromIntrospection to support previous versions of introspection ([#1089](#1089)) ([64604e0](64604e0)) * **sql:** random error on postgresql during introspection caused by left join on information_schema.element_types ([#1090](#1090)) ([2b1d1df](2b1d1df)) * **sql:** type detection for enums in schemas ([#1093](#1093)) ([49d78e3](49d78e3)) * **sql:** users should be able to use table with multiple sequences ([#1087](#1087)) ([9e8b6eb](9e8b6eb)) ### Features * **datasource-customizer:** add override decorator ([#814](#814)) ([21ffef7](21ffef7)) * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **datasource-sql:** add support for views ([#903](#903)) ([1695245](1695245)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13)) * **forest-cloud:** improve a message when there is a 401 http error ([#1081](#1081)) ([358a104](358a104)) * improve error message in case of invalid token ([#1083](#1083)) ([f03d5c7](f03d5c7)) * list collections from an introspection result ([#1086](#1086)) ([2407dc9](2407dc9))

## [1.1.10](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.9...@forestadmin/datasource-dummy@1.1.10) (2024-04-05) ### Bug Fixes * change introspection type to avoid breaking change ([#1095](#1095)) ([42777a0](42777a0)) * **datasource-mongo:** auto introspection does not work ([#1078](#1078)) ([d32456b](d32456b)) * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * introspection format and versions ([#1094](#1094)) ([c11bc31](c11bc31)) * mangodb datasource does not generate introspection ([#1077](#1077)) ([5a06419](5a06419)) * **mongo-datasource:** should return record with empty flattened record ([#1080](#1080)) ([420fbfc](420fbfc)) * **mongo:** introspection of models with more than 30 properties (by default) ([#1088](#1088)) ([c06c064](c06c064)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * replace latesIntrospection to legacyIntrospection ([#1092](#1092)) ([e5e6c73](e5e6c73)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) * **sql:** fix the type of listCollectionsFromIntrospection to support previous versions of introspection ([#1089](#1089)) ([64604e0](64604e0)) * **sql:** random error on postgresql during introspection caused by left join on information_schema.element_types ([#1090](#1090)) ([2b1d1df](2b1d1df)) * **sql:** type detection for enums in schemas ([#1093](#1093)) ([49d78e3](49d78e3)) * **sql:** users should be able to use table with multiple sequences ([#1087](#1087)) ([9e8b6eb](9e8b6eb)) ### Features * **datasource-customizer:** add override decorator ([#814](#814)) ([21ffef7](21ffef7)) * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **datasource-sql:** add support for views ([#903](#903)) ([1695245](1695245)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13)) * **forest-cloud:** improve a message when there is a 401 http error ([#1081](#1081)) ([358a104](358a104)) * improve error message in case of invalid token ([#1083](#1083)) ([f03d5c7](f03d5c7)) * list collections from an introspection result ([#1086](#1086)) ([2407dc9](2407dc9))

## [1.3.69](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.3.68...@forestadmin/plugin-aws-s3@1.3.69) (2024-04-05) ### Bug Fixes * change introspection type to avoid breaking change ([#1095](#1095)) ([42777a0](42777a0)) * **datasource-mongo:** auto introspection does not work ([#1078](#1078)) ([d32456b](d32456b)) * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * introspection format and versions ([#1094](#1094)) ([c11bc31](c11bc31)) * mangodb datasource does not generate introspection ([#1077](#1077)) ([5a06419](5a06419)) * **mongo-datasource:** should return record with empty flattened record ([#1080](#1080)) ([420fbfc](420fbfc)) * **mongo:** introspection of models with more than 30 properties (by default) ([#1088](#1088)) ([c06c064](c06c064)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * replace latesIntrospection to legacyIntrospection ([#1092](#1092)) ([e5e6c73](e5e6c73)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) * **sql:** fix the type of listCollectionsFromIntrospection to support previous versions of introspection ([#1089](#1089)) ([64604e0](64604e0)) * **sql:** random error on postgresql during introspection caused by left join on information_schema.element_types ([#1090](#1090)) ([2b1d1df](2b1d1df)) * **sql:** type detection for enums in schemas ([#1093](#1093)) ([49d78e3](49d78e3)) * **sql:** users should be able to use table with multiple sequences ([#1087](#1087)) ([9e8b6eb](9e8b6eb)) ### Features * **datasource-customizer:** add override decorator ([#814](#814)) ([21ffef7](21ffef7)) * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **datasource-sql:** add support for views ([#903](#903)) ([1695245](1695245)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13)) * **forest-cloud:** improve a message when there is a 401 http error ([#1081](#1081)) ([358a104](358a104)) * improve error message in case of invalid token ([#1083](#1083)) ([f03d5c7](f03d5c7)) * list collections from an introspection result ([#1086](#1086)) ([2407dc9](2407dc9))

## [1.0.81](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.0.80...@forestadmin/plugin-export-advanced@1.0.81) (2024-04-05) ### Bug Fixes * change introspection type to avoid breaking change ([#1095](#1095)) ([42777a0](42777a0)) * **datasource-mongo:** auto introspection does not work ([#1078](#1078)) ([d32456b](d32456b)) * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * introspection format and versions ([#1094](#1094)) ([c11bc31](c11bc31)) * mangodb datasource does not generate introspection ([#1077](#1077)) ([5a06419](5a06419)) * **mongo-datasource:** should return record with empty flattened record ([#1080](#1080)) ([420fbfc](420fbfc)) * **mongo:** introspection of models with more than 30 properties (by default) ([#1088](#1088)) ([c06c064](c06c064)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * replace latesIntrospection to legacyIntrospection ([#1092](#1092)) ([e5e6c73](e5e6c73)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) * **sql:** fix the type of listCollectionsFromIntrospection to support previous versions of introspection ([#1089](#1089)) ([64604e0](64604e0)) * **sql:** random error on postgresql during introspection caused by left join on information_schema.element_types ([#1090](#1090)) ([2b1d1df](2b1d1df)) * **sql:** type detection for enums in schemas ([#1093](#1093)) ([49d78e3](49d78e3)) * **sql:** users should be able to use table with multiple sequences ([#1087](#1087)) ([9e8b6eb](9e8b6eb)) ### Features * **datasource-customizer:** add override decorator ([#814](#814)) ([21ffef7](21ffef7)) * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **datasource-sql:** add support for views ([#903](#903)) ([1695245](1695245)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13)) * **forest-cloud:** improve a message when there is a 401 http error ([#1081](#1081)) ([358a104](358a104)) * improve error message in case of invalid token ([#1083](#1083)) ([f03d5c7](f03d5c7)) * list collections from an introspection result ([#1086](#1086)) ([2407dc9](2407dc9))

## [1.32.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.32.2...@forestadmin/datasource-toolkit@1.32.3) (2024-04-10) ### Bug Fixes * change introspection type to avoid breaking change ([#1095](#1095)) ([42777a0](42777a0)) * **datasource-customizer:** correct confusing type when using addExternalRelation ([#1099](#1099)) ([34e27ab](34e27ab)) * **datasource-mongo:** auto introspection does not work ([#1078](#1078)) ([d32456b](d32456b)) * **forest-cloud:** display an error on upload errors ([#1098](#1098)) ([98e0710](98e0710)) * **forest-cloud:** remove a deprecated warning when updating the typing ([#1074](#1074)) ([7b0c0c2](7b0c0c2)) * improve error message in the case of outdated introspection ([#1101](#1101)) ([ab1bb87](ab1bb87)) * introspection format and versions ([#1094](#1094)) ([c11bc31](c11bc31)) * mangodb datasource does not generate introspection ([#1077](#1077)) ([5a06419](5a06419)) * **mongo-datasource:** should return record with empty flattened record ([#1080](#1080)) ([420fbfc](420fbfc)) * **mongo:** introspection of models with more than 30 properties (by default) ([#1088](#1088)) ([c06c064](c06c064)) * mongoose relation flattened field not showing ([#1076](#1076)) ([0a64c00](0a64c00)) * replace latesIntrospection to legacyIntrospection ([#1092](#1092)) ([e5e6c73](e5e6c73)) * **security:** patch follow-redirects dependency vulnerabilities ([#1073](#1073)) ([cfbf8be](cfbf8be)) * **sql:** fix the type of listCollectionsFromIntrospection to support previous versions of introspection ([#1089](#1089)) ([64604e0](64604e0)) * **sql:** random error on postgresql during introspection caused by left join on information_schema.element_types ([#1090](#1090)) ([2b1d1df](2b1d1df)) * **sql:** type detection for enums in schemas ([#1093](#1093)) ([49d78e3](49d78e3)) * **sql:** users should be able to use table with multiple sequences ([#1087](#1087)) ([9e8b6eb](9e8b6eb)) ### Features * **datasource-customizer:** add override decorator ([#814](#814)) ([21ffef7](21ffef7)) * **datasource-mongo:** add new datasource ([#689](#689)) ([af95276](af95276)) * **datasource-sql:** add support for views ([#903](#903)) ([1695245](1695245)) * **flattener:** allow users to flatten JSON primitive column ([#1071](#1071)) ([fd1db13](fd1db13)) * **forest-cloud:** improve a message when there is a 401 http error ([#1081](#1081)) ([358a104](358a104)) * improve error message in case of invalid token ([#1083](#1083)) ([f03d5c7](f03d5c7)) * list collections from an introspection result ([#1086](#1086)) ([2407dc9](2407dc9)) * support mongodb cloud customizations ([#1097](#1097)) ([65ce409](65ce409))

forest-bot · 2024-04-10T14:23:55Z

🎉 This PR is included in version 1.32.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

feat(flatterner): allow users to flatten JSON column

56654f8

Thenkei changed the title ~~feat(flattener): allow users to flatten JSON column~~ feat(flattener): allow users to flatten JSON primitive column Mar 14, 2024

refactor: export it

312dae0

realSpok reviewed Mar 14, 2024

View reviewed changes

packages/plugin-flattener/src/flatten-json-column/index.ts Outdated Show resolved Hide resolved

realSpok reviewed Mar 14, 2024

View reviewed changes

packages/plugin-flattener/src/flatten-json-column/index.ts Outdated Show resolved Hide resolved

realSpok reviewed Mar 14, 2024

View reviewed changes

packages/plugin-flattener/src/flatten-json-column/index.ts Show resolved Hide resolved

realSpok reviewed Mar 14, 2024

View reviewed changes

refactor: ease solution add allow writable support out of the box

bfcda0a

Thenkei force-pushed the feat/flatten-json-column branch from 1648c44 to bfcda0a Compare March 14, 2024 13:31

Thenkei and others added 4 commits March 14, 2024 14:51

fix: some fixes

0036407

fix: some fixes

ef764ba

feat: review suggestions

13f827f

feat: properly test columnType shape

6393664

realSpok approved these changes Mar 14, 2024

View reviewed changes

Thenkei commented Mar 14, 2024

View reviewed changes

Thenkei added 2 commits March 14, 2024 16:18

test: missing test

f744529

test: add the last missing coverage

0eb7a4d

Thenkei merged commit fd1db13 into main Mar 14, 2024

Thenkei deleted the feat/flatten-json-column branch March 14, 2024 16:40

forest-bot added the released label Mar 14, 2024

	* @param options.columnName The name of the column to import.
	* @param options.columnName The name of the json column that you want to flatten.

	* @param options.columnType The type of the column to import.
	* @param options.columnType a json object representing the shape of the data in the json column, with keys the column names, and values either json (to flatten further) or a primitive type (to define a column)

Conversation

Thenkei commented Mar 14, 2024

Definition of Done

General

Security

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

realSpok Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

realSpok Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

realSpok Mar 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

realSpok left a comment

Choose a reason for hiding this comment

Uh oh!

Thenkei left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot commented Mar 14, 2024

Uh oh!

forest-bot commented Mar 14, 2024

Uh oh!

forest-bot commented Mar 18, 2024

Uh oh!

forest-bot commented Mar 19, 2024

Uh oh!

forest-bot commented Mar 20, 2024

Uh oh!

forest-bot commented Apr 2, 2024

Uh oh!

forest-bot commented Apr 2, 2024

Uh oh!

forest-bot commented Apr 2, 2024

Uh oh!

forest-bot commented Apr 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

realSpok Mar 14, 2024 •

edited

Loading

realSpok Mar 14, 2024 •

edited

Loading

realSpok Mar 14, 2024 •

edited

Loading