Skip to content

fix(mongoose): apply sort on all pages instead of the current page#1188

Merged
Scra3 merged 1 commit intomainfrom
fix-mongoose-sort
Oct 4, 2024
Merged

fix(mongoose): apply sort on all pages instead of the current page#1188
Scra3 merged 1 commit intomainfrom
fix-mongoose-sort

Conversation

@Scra3
Copy link
Copy Markdown
Member

@Scra3 Scra3 commented Oct 3, 2024 •
edited
Loading

linked to: CU-86c0hgwb1

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@Scra3 Scra3 force-pushed the fix-mongoose-sort branch from 4f01a2d to 6910c84 Compare October 3, 2024 11:28
@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 3, 2024

Task linked: CU-86c0hgwb1 🔥🔥🔥 P1 - Sort - Sort is broken on mongoose ds

@Scra3 Scra3 changed the title fix(mongoose): apply sort on the whole pages instead of the current page fix(mongoose): apply sort on all pages instead of the current page Oct 3, 2024
@Scra3 Scra3 force-pushed the fix-mongoose-sort branch from 6910c84 to 8ab5701 Compare October 3, 2024 11:35
realSpok
realSpok approved these changes Oct 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@realSpok realSpok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ✅ Code review
    • ✅ Use pure functions when possible
    • ✅ Performance concerns
    • ✅ Security concerns
    • ✅ The PR tackle one subject only
  • ✅ Automatic tests
    • ✅ Unit tests
    • ⤬ Integration tests
  • ✅ Manual tests
    • ✅ Test the functionality
    • ✅ Test error cases
  • ✅ PR title
  • ✅ Destination branch
  • ✅ PR linked to the clickup task

@Scra3 Scra3 force-pushed the fix-mongoose-sort branch from 8ab5701 to 3f2ea71 Compare October 3, 2024 15:21
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy bot commented Oct 3, 2024

Code Climate has analyzed commit 3f2ea71 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5%.

View more on Code Climate.

@Scra3 Scra3 merged commit 434d183 into main Oct 4, 2024
@Scra3 Scra3 deleted the fix-mongoose-sort branch October 4, 2024 05:00
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): example@1.10.3 [skip ci]
e85f7b2 
## [1.10.3](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.10.2...example@1.10.3) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/datasource-mongoose@1.8.1 [skip ci]
9f2ba03 
## [1.8.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.8.0...@forestadmin/datasource-mongoose@1.8.1) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))
@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.3.21 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/forest-cloud@1.11.18 [skip ci]
cfbb068 
## [1.11.18](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forest-cloud@1.11.17...@forestadmin/forest-cloud@1.11.18) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))
@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.10.3 🎉

The release is available on example@1.10.3

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.8.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.11.18 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/agent@1.48.0 [skip ci]
9a797a3 
# [1.48.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.47.0...@forestadmin/agent@1.48.0) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/datasource-customizer@1.53.0 [skip ci]
8d6f422 
# [1.53.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.52.1...@forestadmin/datasource-customizer@1.53.0) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/datasource-dummy@1.1.32 [skip ci]
9d21647 
## [1.1.32](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.31...@forestadmin/datasource-dummy@1.1.32) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/datasource-replica@1.4.0 [skip ci]
c694efa 
# [1.4.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-replica@1.3.39...@forestadmin/datasource-replica@1.4.0) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/datasource-sequelize@1.10.1 [skip ci]
8a0ae8e 
## [1.10.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.10.0...@forestadmin/datasource-sequelize@1.10.1) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/datasource-sql@1.14.27 [skip ci]
3fba429 
## [1.14.27](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.26...@forestadmin/datasource-sql@1.14.27) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/datasource-toolkit@1.41.0 [skip ci]
dd4b711 
# [1.41.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.40.0...@forestadmin/datasource-toolkit@1.41.0) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/forestadmin-client@1.33.1 [skip ci]
462ccb1 
## [1.33.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.33.0...@forestadmin/forestadmin-client@1.33.1) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.48.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/plugin-aws-s3@1.4.0 [skip ci]
1ff2555 
# [1.4.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.3.91...@forestadmin/plugin-aws-s3@1.4.0) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/plugin-export-advanced@1.1.3 [skip ci]
079826a 
## [1.1.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.1.2...@forestadmin/plugin-export-advanced@1.1.3) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
forest-bot added a commit that referenced this pull request Oct 4, 2024
@forest-bot
chore(release): @forestadmin/plugin-flattener@1.3.0 [skip ci]
049fed4 
# [1.3.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.2.17...@forestadmin/plugin-flattener@1.3.0) (2024-10-04)

### Bug Fixes

* **mongoose:** apply sort on all pages instead of the current page ([#1188](#1188)) ([434d183](434d183))

### Features

* **schema:** send a clear message when user wants to access to an unknown field ([#1186](#1186)) ([016aedd](016aedd))
@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.53.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.1.32 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.10.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.14.27 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.41.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.33.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.1.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Copy Markdown
Member

forest-bot commented Oct 4, 2024

🎉 This PR is included in version 1.3.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@realSpok realSpok realSpok approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Scra3 @forest-bot @realSpok