Skip to content

feat(api chart): allow customizing api chart with query or body parameters#1491

Merged
arnaud-moncel merged 3 commits intomainfrom
feat/api-chart
Mar 18, 2026
Merged

feat(api chart): allow customizing api chart with query or body parameters#1491
arnaud-moncel merged 3 commits intomainfrom
feat/api-chart

Conversation

@arnaud-moncel
Copy link
Copy Markdown
Member

@arnaud-moncel arnaud-moncel commented Mar 16, 2026

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

Note

Allow passing query and body parameters to API chart handlers

  • Adds QueryStringParser.parseChartParameters in query-string.ts to merge context.request.query and context.request.body into a flat Record<string, string>, with body values taking precedence.
  • Passes the parsed parameters as an additional argument to renderChart in both collection and datasource chart routes.
  • Extends CollectionChartContext and the new DataSourceChartContext to expose an immutable parameters object to chart handler callbacks.
  • Updates renderChart signatures across datasource-toolkit interfaces, decorators, and datasource-customizer to thread the optional parameters argument through the full call chain.
  • DataSourceChartContext is a new context class; CollectionChartDefinition and DataSourceChartDefinition are now exported from datasource-customizer.

Macroscope summarized 5cdd942.

@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 16, 2026

4 new issues

Tool Category Rule Count
qlty Structure Function with many parameters (count = 4): renderChart 4

@qltysh
Copy link
Copy Markdown

qltysh bot commented Mar 16, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (9)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
packages/datasource-customizer/src/decorators/chart/collection.ts100.0%
Coverage rating: A Coverage rating: A
...s/datasource-customizer/src/decorators/composite-datasource.ts100.0%
Coverage rating: A Coverage rating: A
packages/datasource-customizer/src/decorators/chart/datasource.ts100.0%
Coverage rating: A Coverage rating: A
...ages/datasource-toolkit/src/decorators/datasource-decorator.ts100.0%
Coverage rating: A Coverage rating: A
...ages/datasource-toolkit/src/decorators/collection-decorator.ts100.0%
Coverage rating: A Coverage rating: A
packages/agent/src/utils/query-string.ts100.0%
Coverage rating: A Coverage rating: A
packages/datasource-customizer/src/index.ts100.0%
Coverage rating: A Coverage rating: A
packages/datasource-customizer/src/decorators/chart/context.ts100.0%
New file Coverage rating: A
...ce-customizer/src/decorators/chart/datasource-chart-context.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@matthv matthv changed the title feat(api chart): allow customizing api chart with query or body parametters feat(api chart): allow customizing api chart with query or body parameters Mar 17, 2026
Copy link
Copy Markdown
Member

@matthv matthv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@arnaud-moncel arnaud-moncel merged commit a7237f2 into main Mar 18, 2026
29 checks passed
@arnaud-moncel arnaud-moncel deleted the feat/api-chart branch March 18, 2026 09:17
forest-bot added a commit that referenced this pull request Mar 18, 2026
# @forestadmin/datasource-toolkit [1.53.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.52.0...@forestadmin/datasource-toolkit@1.53.0) (2026-03-18)

### Features

* **api chart:** allow customizing api chart with query or body parameters ([#1491](#1491)) ([a7237f2](a7237f2))
forest-bot added a commit that referenced this pull request Mar 18, 2026
# @forestadmin/datasource-customizer [1.69.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.68.2...@forestadmin/datasource-customizer@1.69.0) (2026-03-18)

### Features

* **api chart:** allow customizing api chart with query or body parameters ([#1491](#1491)) ([a7237f2](a7237f2))

### Dependencies

* **@forestadmin/datasource-toolkit:** upgraded to 1.53.0
forest-bot added a commit that referenced this pull request Mar 18, 2026
# @forestadmin/agent [1.75.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.74.1...@forestadmin/agent@1.75.0) (2026-03-18)

### Features

* **api chart:** allow customizing api chart with query or body parameters ([#1491](#1491)) ([a7237f2](a7237f2))

### Dependencies

* **@forestadmin/datasource-customizer:** upgraded to 1.69.0
* **@forestadmin/datasource-toolkit:** upgraded to 1.53.0
* **@forestadmin/forestadmin-client:** upgraded to 1.37.18
* **@forestadmin/mcp-server:** upgraded to 1.8.9
* **@forestadmin/datasource-sql:** upgraded to 1.17.8
arnaud-moncel pushed a commit that referenced this pull request Apr 1, 2026
# @forestadmin/datasource-toolkit [1.53.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.52.0...@forestadmin/datasource-toolkit@1.53.0) (2026-03-18)

### Features

* **api chart:** allow customizing api chart with query or body parameters ([#1491](#1491)) ([a7237f2](a7237f2))
arnaud-moncel pushed a commit that referenced this pull request Apr 1, 2026
# @forestadmin/datasource-customizer [1.69.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.68.2...@forestadmin/datasource-customizer@1.69.0) (2026-03-18)

### Features

* **api chart:** allow customizing api chart with query or body parameters ([#1491](#1491)) ([a7237f2](a7237f2))

### Dependencies

* **@forestadmin/datasource-toolkit:** upgraded to 1.53.0
arnaud-moncel pushed a commit that referenced this pull request Apr 1, 2026
# @forestadmin/agent [1.75.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.74.1...@forestadmin/agent@1.75.0) (2026-03-18)

### Features

* **api chart:** allow customizing api chart with query or body parameters ([#1491](#1491)) ([a7237f2](a7237f2))

### Dependencies

* **@forestadmin/datasource-customizer:** upgraded to 1.69.0
* **@forestadmin/datasource-toolkit:** upgraded to 1.53.0
* **@forestadmin/forestadmin-client:** upgraded to 1.37.18
* **@forestadmin/mcp-server:** upgraded to 1.8.9
* **@forestadmin/datasource-sql:** upgraded to 1.17.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants