fix(workflow-executor): align getMcpServerConfigs port with Record shape

[hercemer42]

Summary

• Runner.fetchRemoteTools() crashed with TypeError: configs.map is not a function on every MCP-typed step. The orchestrator's GET /liana/mcp-server-configs-with-details returns Record<string, ToolConfig>, but the executor port was typed Promise<McpConfiguration[]> and the runner called .map on the object.
• Aligns the executor with the wire contract: port now returns McpServers (Record<string, McpServerConfig>, from @forestadmin/ai-proxy), runner wraps the record into { configs } for loadRemoteTools, with an empty-Record short-circuit.
• Updates 9 test mock sites (8 mockResolvedValue([]) plus the [{ configs: {} }] as never cast in runner.test.ts) to the real Record shape so the contract can't silently regress again. Adds two TDD tests under MCP lazy loading (via once thunk) for the non-empty-Record happy path and the empty-Record short-circuit.

Dependency bumps (heads-up)

packages/workflow-executor/package.json bumps:

• @forestadmin/ai-proxy 1.8.0 → 1.9.0 — load-bearing for this fix (the McpServers type only exists from 1.9.0 onward).
• @forestadmin/forestadmin-client 1.39.5 → 1.39.7 — incidental, was already staged in the user's pre-existing main-branch state.

These cannot be split into a separate PR because the workspace-resolved import in src/ports/workflow-port.ts would fail to compile against ai-proxy 1.8.0.

Test plan

• yarn workspace @forestadmin/workflow-executor jest --runInBand --forceExit --testMatch='**/runner.test.ts' — 83/83 pass (including 3 new MCP-lazy-loading tests)
• yarn workspace @forestadmin/workflow-executor jest --runInBand --forceExit on the 9 changed test files — 361 tests green
• npx eslint, npx prettier --check, npx tsc --noEmit on all 13 changed files — clean
• End-to-end repro against data-gouv MCP server on the executor dev project — pre-fix run aborted with the generic "An unexpected error occurred." (masking the TypeError); post-fix run reports NoMcpToolsError cleanly, which is the legitimate downstream behaviour when no tools materialize

Refs: PRD-357

Note

Fix getMcpServerConfigs return type to use McpServers Record shape in workflow-executor

• Replaces McpConfiguration[] array with McpServers (a Record<string, ToolConfig> map) as the return type of getMcpServerConfigs across workflow-port.ts, forest-server-workflow-port.ts, and the public exports in index.ts.
• Updates Runner.fetchRemoteTools in runner.ts to skip calling aiModelPort.loadRemoteTools when the config map is empty, and passes { configs } (the Record wrapped in an object) when non-empty.
• Bumps @forestadmin/ai-proxy to 1.9.0 and @forestadmin/forestadmin-client to 1.39.7.
• Behavioral Change: loadRemoteTools is no longer called when the orchestrator returns an empty MCP config map; callers relying on the old array format for getMcpServerConfigs will need to update to the Record shape.

Changes since #1583 opened

• Fixed McpStepExecutor.getFilteredTools to filter tools by tool.mcpServerId instead of tool.sourceId when a step specifies mcpServerId, and updated NoMcpToolsError to include diagnostic context showing the requested mcpServerId and list of available mcpServerIds when filtering yields no matches [53618a7]
• Added optional mcpServerId property to RemoteTool class and threaded it through ServerRemoteTool and McpServerRemoteTool subclass constructors [53618a7]
• Modified McpClient to extract id from each server config entry, store it in an internal mcpServerIdsByName map, and populate mcpServerId on McpServerRemoteTool instances during tool loading, and changed McpConfiguration.configs type from MultiServerMCPClient['config']['mcpServers'] to Record<string, McpServerConfig> where McpServerConfig includes optional id?: string [53618a7]
• Extended ForestIntegrationConfig interface with optional id?: string and updated ForestIntegrationClient.loadTools to thread this id as mcpServerId parameter to getZendeskTools, getKolarTools, and getSnowflakeTools factory functions, which were each extended to accept optional mcpServerId and pass it to ServerRemoteTool constructor [53618a7]
• Added test coverage for mcpServerId propagation across ForestIntegrationClient, integration tool factories (getZendeskTools, getKolarTools, getSnowflakeTools), McpClient, McpStepExecutor filtering behavior, and NoMcpToolsError message construction [53618a7]

^{Macroscope summarized 480148c.}

[linear]

PRD-357

[qltysh]

Coverage Impact

⬆️ Merging this pull request will increase total coverage on feat/prd-214-server-step-mapper by 0.01%.

Modified Files with Diff Coverage (10)

Rating	File	% Diff	Uncovered Line #s
	packages/workflow-executor/src/runner.ts	100.0%
	packages/ai-proxy/src/integrations/snowflake/tools.ts	100.0%
	packages/ai-proxy/src/remote-tool.ts	100.0%
	packages/ai-proxy/src/integrations/zendesk/tools.ts	100.0%
	packages/ai-proxy/src/forest-integration-client.ts	100.0%
	.../workflow-executor/src/adapters/forest-server-workflow-port.ts	100.0%
	packages/ai-proxy/src/mcp-client.ts	100.0%
	packages/ai-proxy/src/integrations/kolar/tools.ts	100.0%
	packages/workflow-executor/src/errors.ts	100.0%
	packages/workflow-executor/src/executors/mcp-step-executor.ts	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

[matthv]

LGTM. Clean fix 🏅