fix(workflow-executor): single source of truth for CLI defaults

[nbouliol]

Summary

• Created src/defaults.ts exporting all 6 CLI-visible defaults (DEFAULT_HTTP_PORT, DEFAULT_FOREST_SERVER_URL, DEFAULT_POLLING_INTERVAL_MS, DEFAULT_STEP_TIMEOUT_MS, DEFAULT_STOP_TIMEOUT_MS, DEFAULT_MAX_CHAIN_DEPTH).
• build-workflow-executor.ts, runner.ts, and cli-core.ts now import from defaults.ts instead of duplicating constants.
• logStartup now resolves forestServerUrl/pollingIntervalMs against the defaults so logged values match runtime behavior (previously logged undefined when env vars were unset).

fixes PRD-394

Test plan

• yarn workspace @forestadmin/workflow-executor test (774 passing)
• yarn workspace @forestadmin/workflow-executor lint (no new warnings)
• yarn workspace @forestadmin/workflow-executor build
• New test asserts printHelp output contains every default value
• New test asserts logStartup logs resolved defaults when env-derived options are undefined

🤖 Generated with Claude Code

Note

Centralize CLI default constants in workflow-executor into a single defaults module

• Introduces defaults.ts as the single source of truth for DEFAULT_HTTP_PORT, DEFAULT_FOREST_SERVER_URL, DEFAULT_POLLING_INTERVAL_MS, DEFAULT_STEP_TIMEOUT_MS, DEFAULT_STOP_TIMEOUT_MS, and DEFAULT_MAX_CHAIN_DEPTH.
• Updates cli-core.ts, build-workflow-executor.ts, and runner.ts to import from ./defaults instead of defining constants locally.
• logStartup now logs the default pollingIntervalMs value when none is provided, closing a gap in startup output.
• Behavioral Change: DEFAULT_POLLING_INTERVAL_MS is no longer exported from build-workflow-executor; consumers must import it from ./defaults.

^{Macroscope summarized 729eacb.}

[linear]

PRD-394

[qltysh]

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (4)

Rating	File	% Diff	Uncovered Line #s
	packages/workflow-executor/src/runner.ts	100.0%
	packages/workflow-executor/src/build-workflow-executor.ts	100.0%
	packages/workflow-executor/src/cli-core.ts	100.0%
	packages/workflow-executor/src/defaults.ts	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.