Skip to content

fix(workflow-executor): always log WorkflowExecutorError message, even without cause#1601

Merged
Scra3 merged 1 commit into
feat/prd-214-server-step-mapperfrom
fix/log-workflow-executor-error-without-cause
May 27, 2026
Merged

fix(workflow-executor): always log WorkflowExecutorError message, even without cause#1601
Scra3 merged 1 commit into
feat/prd-214-server-step-mapperfrom
fix/log-workflow-executor-error-without-cause

Conversation

@Scra3
Copy link
Copy Markdown
Member

@Scra3 Scra3 commented May 27, 2026

Summary

  • WorkflowExecutorError thrown without a cause (e.g. Zod validation failure on pendingData) was silently swallowed — no log on the executor side
  • Now always logs error.message; cause and stack are appended when present

Test plan

  • base-step-executor.test.ts updated: verifies logger.error is called with the error message even when no cause is set
  • 791 tests passing

fixes PRD-214

🤖 Generated with Claude Code

Note

Fix BaseStepExecutor to always log WorkflowExecutorError message even without a cause

Previously, WorkflowExecutorError instances without a cause were silently swallowed — no error log was emitted. The fix removes the conditional guard in base-step-executor.ts so logger.error is always called with error.message. When a cause is present, logging behavior is unchanged (message, cause, stack).

Macroscope summarized 347f1f2.

@linear
Copy link
Copy Markdown

linear Bot commented May 27, 2026

PRD-214

@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 27, 2026

2 new issues

Tool Category Rule Count
qlty Structure Function with many returns (count = 5): execute 1
qlty Structure Function with high complexity (count = 11): execute 1

@Scra3 Scra3 force-pushed the fix/log-workflow-executor-error-without-cause branch from 32cfcbe to 2930457 Compare May 27, 2026 14:06
@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 27, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
packages/workflow-executor/src/executors/base-step-executor.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@Scra3 Scra3 force-pushed the fix/log-workflow-executor-error-without-cause branch from 2930457 to 45737ee Compare May 27, 2026 14:17
…n without cause

Previously the error was silently swallowed when no cause was set,
making Zod validation failures (e.g. invalid pending data) invisible
in executor logs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Scra3 Scra3 force-pushed the fix/log-workflow-executor-error-without-cause branch from 45737ee to 347f1f2 Compare May 27, 2026 14:18
@Scra3 Scra3 merged commit 9449852 into feat/prd-214-server-step-mapper May 27, 2026
29 of 30 checks passed
@Scra3 Scra3 deleted the fix/log-workflow-executor-error-without-cause branch May 27, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants