fix(workflow-executor): always log WorkflowExecutorError message, even without cause#1601
Merged
Scra3 merged 1 commit intoMay 27, 2026
Conversation
2 new issues
|
32cfcbe to
2930457
Compare
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (1)
🛟 Help
|
2930457 to
45737ee
Compare
…n without cause Previously the error was silently swallowed when no cause was set, making Zod validation failures (e.g. invalid pending data) invisible in executor logs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
45737ee to
347f1f2
Compare
nbouliol
approved these changes
May 27, 2026
9449852
into
feat/prd-214-server-step-mapper
29 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
WorkflowExecutorErrorthrown without acause(e.g. Zod validation failure onpendingData) was silently swallowed — no log on the executor sideerror.message;causeandstackare appended when presentTest plan
base-step-executor.test.tsupdated: verifieslogger.erroris called with the error message even when no cause is setfixes PRD-214
🤖 Generated with Claude Code
Note
Fix
BaseStepExecutorto always logWorkflowExecutorErrormessage even without a causePreviously,
WorkflowExecutorErrorinstances without acausewere silently swallowed — no error log was emitted. The fix removes the conditional guard inbase-step-executor.tssologger.erroris always called witherror.message. When a cause is present, logging behavior is unchanged (message, cause, stack).Macroscope summarized 347f1f2.