Skip to content

fix(workflow-executor): self-descriptive log messages for activity log operations#1602

Merged
Scra3 merged 1 commit into
feat/prd-214-server-step-mapperfrom
fix/activity-log-log-messages
May 28, 2026
Merged

fix(workflow-executor): self-descriptive log messages for activity log operations#1602
Scra3 merged 1 commit into
feat/prd-214-server-step-mapperfrom
fix/activity-log-log-messages

Conversation

@Scra3
Copy link
Copy Markdown
Member

@Scra3 Scra3 commented May 27, 2026

Summary

  • Replaced opaque Activity log markSucceeded / Activity log markFailed / Activity log createPending labels with self-descriptive messages readable without field inspection
  • Pattern: activity log <operation> failed for errors, "activity log <operation>" failed, retrying for retries

Before:

warn: "Activity log markSucceeded" failed, retrying
error: Failed to mark activity log as succeeded

After:

warn: "activity log mark-as-completed" failed, retrying
error: activity log mark-as-completed failed

🤖 Generated with Claude Code

Note

Standardize log message format for activity log operations in workflow-executor

Updates the withRetry operation labels and error log messages in ForestadminClientActivityLogPort to use a consistent lowercase hyphenated format (e.g. activity log create, activity log mark-as-completed failed) instead of the previous mixed-case camelCase style. Test expectations in the corresponding test file are updated to match.

Macroscope summarized b46209a.

…y log operations

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 27, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
...-executor/src/adapters/forestadmin-client-activity-log-port.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@Scra3 Scra3 merged commit 1287046 into feat/prd-214-server-step-mapper May 28, 2026
56 of 57 checks passed
@Scra3 Scra3 deleted the fix/activity-log-log-messages branch May 28, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants